Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show onProperties tab for database. - Mailing list pgadmin-hackers

Patch looks good to me.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Aug 8, 2017 at 3:25 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:

makes sense. Thanks for the solution.

Please find attached revised patch.

Thanks,

Atul

On Tue, Aug 8, 2017 at 2:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Atul,

Better solution to solve this issue is to use self.conn instead of creating new conn using did, we already checking for "datallowconn" flag in check_precondition decorator.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Aug 8, 2017 at 12:42 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:

ok, Lemme check and I will get back to you.

Thanks,

Atul

On Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Atul,

The given patch breaks RM#1801.

After applying the patch, Now I'm not able to see the properties of a database of which "datallowconn" is set to False.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Murtuza,

Please review this one.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:

Hi,

PFA patch that fixes Default privileges don't show on Properties tab for database

Thanks,

Atul