Thread: [HACKERS] Notice message of ALTER SUBSCRIPTION ... RERESH PUBLICATIION
Hi, When we run ALTER SUBSCRIPTION ... REFRESH PUBLICATION and there is an unkown table at local, it says; NOTICE: added subscription for table public.tbl I feel this a bit misleading because it says a subscription is added but actually new subscription object is not created. Of cause, I can understand the intention this message says, but I feel that it is better to use other expression. For example, how about saying NOTICE: table public.tbl is added to subscription sub1 as proposed in the attached patch. This also fixes the message when a table is removed from a subscription. Regards, -- Yugo Nagata <nagata@sraoss.co.jp> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Attachment
Re: [HACKERS] Notice message of ALTER SUBSCRIPTION ... RERESHPUBLICATIION
From
Peter Eisentraut
Date:
On 7/27/17 20:51, Yugo Nagata wrote: > When we run ALTER SUBSCRIPTION ... REFRESH PUBLICATION and there is > an unkown table at local, it says; > > NOTICE: added subscription for table public.tbl > > I feel this a bit misleading because it says a subscription is added > but actually new subscription object is not created. Of cause, I can > understand the intention this message says, but I feel that > it is better to use other expression. For example, how about saying > > NOTICE: table public.tbl is added to subscription sub1 > > as proposed in the attached patch. This also fixes the message > when a table is removed from a subscription. Fixed, thanks. (Note that per another discussion, these are now DEBUG messages.) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Mon, 7 Aug 2017 09:46:56 -0400 Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > On 7/27/17 20:51, Yugo Nagata wrote: > > When we run ALTER SUBSCRIPTION ... REFRESH PUBLICATION and there is > > an unkown table at local, it says; > > > > NOTICE: added subscription for table public.tbl > > > > I feel this a bit misleading because it says a subscription is added > > but actually new subscription object is not created. Of cause, I can > > understand the intention this message says, but I feel that > > it is better to use other expression. For example, how about saying > > > > NOTICE: table public.tbl is added to subscription sub1 > > > > as proposed in the attached patch. This also fixes the message > > when a table is removed from a subscription. > > Fixed, thanks. (Note that per another discussion, these are now DEBUG > messages.) Thanks, too. > > -- > Peter Eisentraut http://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Yugo Nagata <nagata@sraoss.co.jp>