[HACKERS] Notice message of ALTER SUBSCRIPTION ... RERESH PUBLICATIION - Mailing list pgsql-hackers

From Yugo Nagata
Subject [HACKERS] Notice message of ALTER SUBSCRIPTION ... RERESH PUBLICATIION
Date
Msg-id 20170728095117.cf2dc7c6.nagata@sraoss.co.jp
Whole thread Raw
Responses Re: [HACKERS] Notice message of ALTER SUBSCRIPTION ... RERESHPUBLICATIION
List pgsql-hackers
Hi,

When we run ALTER SUBSCRIPTION ... REFRESH PUBLICATION and there is 
an unkown table at local, it says;

 NOTICE:  added subscription for table public.tbl

I feel this a bit misleading because it says a subscription is added
but actually new subscription object is not created. Of cause, I can
understand the intention this message says, but I feel that
it is better to use other expression. For example, how about saying

 NOTICE:  table public.tbl is added to subscription sub1

as proposed in the attached patch. This also fixes the message
when a table is removed from a subscription. 

Regards,

-- 
Yugo Nagata <nagata@sraoss.co.jp>

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)
Next
From: Yugo Nagata
Date:
Subject: [HACKERS] A suspicious code in pgoutput_startup().