Thread: [HACKERS] Incorrect comment in 001_ssltests.pl

Hi all,

I have noticed the following thing:
--- a/src/test/ssl/t/001_ssltests.pl
+++ b/src/test/ssl/t/001_ssltests.pl
@@ -34,8 +34,6 @@ sub run_test_psql
 # The first argument is a (part of a) connection string, and it's also printed
 # out as the test case name. It is appended to $common_connstr global variable,
 # which also contains a libpq connection string.
-#
-# The second argument is a hostname to connect to.
 sub test_connect_ok
 {
    my $connstr = $_[0]

But test_connect_ok and test_connect_fails do not have a second
argument as the hostname is appended directly into $common_connstr.

(I am thinking as well that run_test_psql, test_connect_ok and
test_connect_fails ought to be moved to ServerSetup.pm so as other SSL
tests can take advantage of them, but that's another story for another
day.)

Thanks,
-- 
Michael

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Sat, Jun 17, 2017 at 5:20 PM, Magnus Hagander <magnus@hagander.net> wrote:
> One could argue that the first sentences should just read "the argument"
> once the second one isn't referred, but I can't get too excited about that.
> Thus, patch applied as-is - thanks!

Thanks.
-- 
Michael