Re: [HACKERS] Incorrect comment in 001_ssltests.pl - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [HACKERS] Incorrect comment in 001_ssltests.pl
Date
Msg-id CABUevEwXM0Zs0jwwg4s5tAv7cdCr0f3Ecx4nXCG28aZ=2SFxyA@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Incorrect comment in 001_ssltests.pl  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] Incorrect comment in 001_ssltests.pl
List pgsql-hackers


On Sat, Jun 17, 2017 at 1:53 AM, Michael Paquier <michael.paquier@gmail.com> wrote:
Hi all,

I have noticed the following thing:
--- a/src/test/ssl/t/001_ssltests.pl
+++ b/src/test/ssl/t/001_ssltests.pl
@@ -34,8 +34,6 @@ sub run_test_psql
 # The first argument is a (part of a) connection string, and it's also printed
 # out as the test case name. It is appended to $common_connstr global variable,
 # which also contains a libpq connection string.
-#
-# The second argument is a hostname to connect to.
 sub test_connect_ok
 {
    my $connstr = $_[0]

But test_connect_ok and test_connect_fails do not have a second
argument as the hostname is appended directly into $common_connstr.

One could argue that the first sentences should just read "the argument" once the second one isn't referred, but I can't get too excited about that. Thus, patch applied as-is - thanks! 

--

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] Typos in comments
Next
From: Marina Polyakova
Date:
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors