Postgres Pro
Downloads
Home   >   mailing lists

Thread: [HACKERS] pg_upgrade translation

[HACKERS] pg_upgrade translation

From
Alvaro Herrera
Date:
Translatability was turned on for pg_upgrade on pg10, but it needs some
work.  The choices are we fix it now, or we revert the addition of NLS
there and we do it for PG11.

I think the ugliest one is to change the messages about "the %s server",
which are about a dozen -- things like:
    msgid "pg_ctl failed to start the %s server, or connection failed\n"
where the %s is either "new" or "old".

These need be to be split in two messages, and I think I'd replace the
"old" with "source" and "new" with "target".  Something like this:

*** a/src/bin/pg_upgrade/server.c
--- b/src/bin/pg_upgrade/server.c
***************
*** 285,293 **** start_postmaster(ClusterInfo *cluster, bool throw_error)
                 PQerrorMessage(conn));
          if (conn)
              PQfinish(conn);
!         pg_fatal("could not connect to %s postmaster started with the command:\n"
!                  "%s\n",
!                  CLUSTER_NAME(cluster), cmd);
      }
      PQfinish(conn);

--- 285,297 ----
                 PQerrorMessage(conn));
          if (conn)
              PQfinish(conn);
!         if (cluster == &old_cluster)
!             pg_fatal("could not connect to source postmaster started with the command:\n"
!                      "%s\n", cmd);
!         else
!             pg_fatal("could not connect to target postmaster started with the command:\n"
!                      "%s\n", cmd);
!
      }
      PQfinish(conn);



Aye or nay?

--
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] pg_upgrade translation

From
Robert Haas
Date:
On Mon, May 22, 2017 at 8:28 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Translatability was turned on for pg_upgrade on pg10, but it needs some
> work.  The choices are we fix it now, or we revert the addition of NLS
> there and we do it for PG11.
>
> I think the ugliest one is to change the messages about "the %s server",
> which are about a dozen -- things like:
>     msgid "pg_ctl failed to start the %s server, or connection failed\n"
> where the %s is either "new" or "old".
>
> These need be to be split in two messages, and I think I'd replace the
> "old" with "source" and "new" with "target".
>
> Aye or nay?

Aye.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [HACKERS] pg_upgrade translation

From
Tom Lane
Date:
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, May 22, 2017 at 8:28 PM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:
>> Translatability was turned on for pg_upgrade on pg10, but it needs some
>> work.  The choices are we fix it now, or we revert the addition of NLS
>> there and we do it for PG11.
>> Aye or nay?

> Aye.

+1

            regards, tom lane

Re: [HACKERS] [pgsql-translators] pg_upgrade translation

From
Alvaro Herrera
Date:
Alvaro Herrera wrote:
> Translatability was turned on for pg_upgrade on pg10, but it needs some
> work.  The choices are we fix it now, or we revert the addition of NLS
> there and we do it for PG11.

Here are two patches to fix the messages, replacing "new" with "target"
and "old" with "source".  I was going to do just the first one
initially, but I figured that the output would become wildly
inconsistent if I stopped at that point.

Now we still have one inconsistency left: the command-line options
--old-bindir --new-datadir etc all contain the words "new" and "old".
Same with a bunch of environment variables.  I think the real solution
is that we should change those to --source-bindir and --target-datadir
respectively (and the other ones continue to work for backwards
compatibility), but then maybe leave them alone.

I'll continue fixing things.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachment