Thread: [HACKERS] Why is get_cheapest_parallel_safe_total_inner() in pathkeys.c?
This probably ended up here because there's a bunch of other functions named get_cheapest* in that file, but all of those relate to getting a path for specific PathKeys. get_cheapest_parallel_safe_total_inner() does not do that. Maybe allpaths.c is a better home for it? It seems to have been added in [1] [1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=a71f10189dc10a2fe422158a2c9409e0f77c6b9e -- David Rowley http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
On Fri, Apr 21, 2017 at 12:10 PM, David Rowley <david.rowley@2ndquadrant.com> wrote: > This probably ended up here because there's a bunch of other functions > named get_cheapest* in that file, but all of those relate to getting a > path for specific PathKeys. get_cheapest_parallel_safe_total_inner() > does not do that. Yes, I just put it near to the code from which it was derived. > Maybe allpaths.c is a better home for it? I will let others be the judge of that. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company