Postgres Pro
Downloads
Home   >   mailing lists

Thread: [HACKERS] src/test/regress's check-prepared-txns target

[HACKERS] src/test/regress's check-prepared-txns target

From
Andres Freund
Date:
Hi,

In https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=ae55d9fbe3871a5e6309d9b91629f1b0ff2b8cba
src/test/regress grew a check-prepared-txns (and an accompanying
installcheck-prepared-txns) target.

Is that still sensible given that pg_regress actually enables prepared
transactions?  I bet these tests are run just about never.

I'd suggest removing at least check-prepared-txns and adding the test to
the normal check target (which is guaranteed to have prepared xacts enabled).

Greetings,

Andres Freund

Re: [HACKERS] src/test/regress's check-prepared-txns target

From
Andrew Dunstan
Date:

On 03/11/2017 06:00 PM, Andres Freund wrote:
> Hi,
>
> In https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=ae55d9fbe3871a5e6309d9b91629f1b0ff2b8cba
> src/test/regress grew a check-prepared-txns (and an accompanying
> installcheck-prepared-txns) target.
>
> Is that still sensible given that pg_regress actually enables prepared
> transactions?  I bet these tests are run just about never.
>
> I'd suggest removing at least check-prepared-txns and adding the test to
> the normal check target (which is guaranteed to have prepared xacts enabled).
>

Sounds reasonable.

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services