Postgres Pro
Downloads
Home   >   mailing lists

[HACKERS] src/test/regress's check-prepared-txns target - Mailing list pgsql-hackers

From Andres Freund
Subject [HACKERS] src/test/regress's check-prepared-txns target
Date
Msg-id 20170311230017.6rnrhgc3tbidlpcl@alap3.anarazel.de
Whole thread Raw
Responses Re: [HACKERS] src/test/regress's check-prepared-txns target  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Hi,

In https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=ae55d9fbe3871a5e6309d9b91629f1b0ff2b8cba
src/test/regress grew a check-prepared-txns (and an accompanying
installcheck-prepared-txns) target.

Is that still sensible given that pg_regress actually enables prepared
transactions?  I bet these tests are run just about never.

I'd suggest removing at least check-prepared-txns and adding the test to
the normal check target (which is guaranteed to have prepared xacts enabled).

Greetings,

Andres Freund

pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: [HACKERS] Changing references of password encryption to hashing
Next
From: Joe Conway
Date:
Subject: Re: [HACKERS] scram and \password