Thread: [pgadmin-hackers] pgAdmin4 mirror issues [pgAdmin4]
Hi,
While fixing and testing Unicode issues throughout pgadmin4 nodes I found bellow issues (other than Unicode) which was preventing me further testing. So these need to checked in first before we can apply Unicode related issue patch.1. event_trigger_sql.patch: returns correct value of 'eventfunname' when schema of of trgger function is other than public.
2.check_constraint_sql.patch: Wrong sql was generated for check constraint when we rename table name and check name at the same time from table edit mode.
3.dependents_sql.patch: dependents sql was failing because of following issue.
On non utf-8 encoding database bellow type casting queries fail as it treats 0 (zero) as null instead of integer.
SELECT 0::text;
SELECT CAST(0 AS text);
SELECT CAST(0 AS text);
db error:
ERROR: null character not permitted
********** Error **********
ERROR: null character not permitted
SQL state: 54000
********** Error **********
ERROR: null character not permitted
SQL state: 54000
--
Harshal Dhumal
Software Engineer
Attachment
Hi Can you create RMs for each one please? We need to track fixes. Thanks. On Thu, Feb 23, 2017 at 10:34 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: > Hi, > > While fixing and testing Unicode issues throughout pgadmin4 nodes I found > bellow issues (other than Unicode) which was preventing me further testing. > So these need to checked in first before we can apply Unicode related issue > patch. > > 1. event_trigger_sql.patch: returns correct value of 'eventfunname' when > schema of of trgger function is other than public. > > 2.check_constraint_sql.patch: Wrong sql was generated for check constraint > when we rename table name and check name at the same time from table edit > mode. > > 3.dependents_sql.patch: dependents sql was failing because of following > issue. > On non utf-8 encoding database bellow type casting queries fail as it > treats 0 (zero) as null instead of integer. > > SELECT 0::text; > > SELECT CAST(0 AS text); > > db error: > ERROR: null character not permitted > > ********** Error ********** > > ERROR: null character not permitted > SQL state: 54000 > > > > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
--
Regards,
On Thu, Feb 23, 2017 at 4:12 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi
Can you create RMs for each one please? We need to track fixes.
Thanks.
On Thu, Feb 23, 2017 at 10:34 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> While fixing and testing Unicode issues throughout pgadmin4 nodes I found
> bellow issues (other than Unicode) which was preventing me further testing.
> So these need to checked in first before we can apply Unicode related issue
> patch.
>
> 1. event_trigger_sql.patch: returns correct value of 'eventfunname' when
> schema of of trgger function is other than public.
>
> 2.check_constraint_sql.patch: Wrong sql was generated for check constraint
> when we rename table name and check name at the same time from table edit
> mode.
>
> 3.dependents_sql.patch: dependents sql was failing because of following
> issue.
> On non utf-8 encoding database bellow type casting queries fail as it
> treats 0 (zero) as null instead of integer.
>
> SELECT 0::text;
>
> SELECT CAST(0 AS text);
>
> db error:
> ERROR: null character not permitted
>
> ********** Error **********
>
> ERROR: null character not permitted
> SQL state: 54000
>
>
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Thanks, all applied. On Thu, Feb 23, 2017 at 12:00 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > RM created, > > https://redmine.postgresql.org/issues/2200 > https://redmine.postgresql.org/issues/2201 > https://redmine.postgresql.org/issues/2202 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Feb 23, 2017 at 4:12 PM, Dave Page <dpage@pgadmin.org> wrote: >> >> Hi >> >> Can you create RMs for each one please? We need to track fixes. >> >> Thanks. >> >> On Thu, Feb 23, 2017 at 10:34 AM, Harshal Dhumal >> <harshal.dhumal@enterprisedb.com> wrote: >> > Hi, >> > >> > While fixing and testing Unicode issues throughout pgadmin4 nodes I >> > found >> > bellow issues (other than Unicode) which was preventing me further >> > testing. >> > So these need to checked in first before we can apply Unicode related >> > issue >> > patch. >> > >> > 1. event_trigger_sql.patch: returns correct value of 'eventfunname' when >> > schema of of trgger function is other than public. >> > >> > 2.check_constraint_sql.patch: Wrong sql was generated for check >> > constraint >> > when we rename table name and check name at the same time from table >> > edit >> > mode. >> > >> > 3.dependents_sql.patch: dependents sql was failing because of following >> > issue. >> > On non utf-8 encoding database bellow type casting queries fail as >> > it >> > treats 0 (zero) as null instead of integer. >> > >> > SELECT 0::text; >> > >> > SELECT CAST(0 AS text); >> > >> > db error: >> > ERROR: null character not permitted >> > >> > ********** Error ********** >> > >> > ERROR: null character not permitted >> > SQL state: 54000 >> > >> > >> > >> > >> > -- >> > Harshal Dhumal >> > Software Engineer >> > >> > EnterpriseDB India: http://www.enterprisedb.com >> > The Enterprise PostgreSQL Company >> > >> > >> > -- >> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> > To make changes to your subscription: >> > http://www.postgresql.org/mailpref/pgadmin-hackers >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company