Thread: [HACKERS] Redundant comment in ExecutePlan

[HACKERS] Redundant comment in ExecutePlan

From
Rafia Sabih
Date:
Hello all,
I noticed there is a redundant comment in ExecutePlan,

/*
* If a tuple count was supplied, we must force the plan to run without
* parallelism, because we might exit early.  Also disable parallelism
* when writing into a relation, because no database changes are allowed
* in parallel mode.
*/
if (numberTuples || dest->mydest == DestIntoRel)
use_parallel_mode = false;

/*
* If a tuple count was supplied, we must force the plan to run without
* parallelism, because we might exit early.
*/
if (use_parallel_mode)
EnterParallelMode();

I felt it is not required the second time, hence attached is the patch
to remove this second comment.
-- 
Regards,
Rafia Sabih
EnterpriseDB: http://www.enterprisedb.com/

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

Re: [HACKERS] Redundant comment in ExecutePlan

From
Robert Haas
Date:
On Fri, Feb 3, 2017 at 6:07 AM, Rafia Sabih
<rafia.sabih@enterprisedb.com> wrote:
> Hello all,
> I noticed there is a redundant comment in ExecutePlan,

Hmm, yeah.  Thanks for the patch.  Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company