Thread: Trouble with requirement django-htmlmin

Trouble with requirement django-htmlmin

From
Bruno Friedmann
Date:
Hello there,

I would like to know why the django-htmlmin module has been choosen compared
to Flask-Htmlmin or simply htmlmin.

The trouble, of django-htmlmin is that it tries to install and override
htmlmin installation.

I've open up a ticket upstream
https://github.com/cobrateam/django-htmlmin/issues/107
but no anwser.

So my question would be, is it possible to consider a move to Flask-htmlmin
of htmlmin (as pgAdmin4 is mostly a Flask apps) ?

What would be the best approach ?

a) open a bug against pgAdmin 4
b) create the needed patch
c) send the patch

Thanks for your consideration, and hope to see most of you in Talinn.

--

Bruno Friedmann
 Ioda-Net Sàrl www.ioda-net.ch
 Bareos Partner, openSUSE Member, fsfe fellowship
 GPG KEY : D5C9B751C4653227
 irc: tigerfoot




Re: Trouble with requirement django-htmlmin

From
Dave Page
Date:
Hi

On Sunday, October 30, 2016, Bruno Friedmann <bruno@ioda-net.ch> wrote:
Hello there,

I would like to know why the django-htmlmin module has been choosen compared
to Flask-Htmlmin or simply htmlmin.

To be honest, because I didn't find Flask-Htmlmin when searching. It's also worth nothing that that code is a little experimental. For example, it won't work with the docs unfortunately (which needs fixing).
 

The trouble, of django-htmlmin is that it tries to install and override
htmlmin installation.

Urgh.
 

I've open up a ticket upstream
https://github.com/cobrateam/django-htmlmin/issues/107
but no anwser.

So my question would be, is it possible to consider a move to Flask-htmlmin
of htmlmin (as pgAdmin4 is mostly a Flask apps) ?

Sure.
 

What would be the best approach ?

a) open a bug against pgAdmin 4
b) create the needed patch
c) send the patch

Yes - exactly that process :-)
 

Thanks for your consideration, and hope to see most of you in Talinn.


I'll be there, see you soon.

Regards, Dave. 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company