Thread: git.postgresql.org not finding a commit
Details below, but http://git.postgresql.org/gitweb/?p=postgresql.git&a=search&h=HEAD&st=commit&s=0ac5ad5134f2769ccbaefec73844f8504c4d6182 showsnothing, but that commit does exist: decibel@decina:[15:12]~/pgsql/HEAD/src/backend (master=)$git log 0ac5ad5134f2769ccbaefec73844f8504c4d6182|head -n1 commit 0ac5ad5134f2769ccbaefec73844f8504c4d6182 Our github mirror doesn't show that commit in it's search either :( -------- Original Message -------- Subject: Re: [HACKERS] tracking commit timestamps Date: Tue, 11 Nov 2014 15:18:17 -0600 From: Jim Nasby <Jim.Nasby@BlueTreble.com> To: Alvaro Herrera <alvherre@2ndquadrant.com> CC: Robert Haas <robertmhaas@gmail.com>, Petr Jelinek <petr@2ndquadrant.com>, Steve Singer <steve@ssinger.info>, Andres Freund<andres@2ndquadrant.com>, Michael Paquier <michael.paquier@gmail.com>, Anssi Kääriäinen <anssi.kaariainen@thl.fi>,Simon Riggs <simon@2ndquadrant.com>, Heikki Linnakangas <hlinnakangas@vmware.com>, "Pg Hackers"<pgsql-hackers@postgresql.org>, Jaime Casanova <jaime@2ndquadrant.com> On 11/11/14, 2:03 PM, Alvaro Herrera wrote: > Jim Nasby wrote: >> On 11/10/14, 7:40 AM, Alvaro Herrera wrote: > >>> Ah, right. So AFAIK we don't need to keep anything older than >>> RecentXmin or something like that -- which is not too old. If I recall >>> correctly Josh Berkus was saying in a thread about pg_multixact that it >>> used about 128kB or so in <= 9.2 for his customers; that one was also >>> limited to RecentXmin AFAIR. I think a similar volume of commit_ts data >>> would be pretty acceptable. Moreso considering that it's turned off by >>> default. >> >> FWIW, AFAICS MultiXacts are only truncated after a (auto)vacuum process is able to advance datminmxid, which will (now)only happen when an entire relation has been scanned (which should be infrequent). >> >> I believe the low normal space usage is just an indication that most databases don't use many MultiXacts. > > That's in 9.3. Prior to that, they were truncated much more often. Well, we're talking about a new feature, so I wasn't looking in back branches. ;P > Maybe you've not heard enough about this commit: > > commit 0ac5ad5134f2769ccbaefec73844f8504c4d6182 Interestingly, git.postgresql.org hasn't either: http://git.postgresql.org/gitweb/?p=postgresql.git&a=search&h=HEAD&st=commit&s=0ac5ad5134f2769ccbaefec73844f8504c4d6182 The commit is certainly there though... decibel@decina:[15:12]~/pgsql/HEAD/src/backend (master=)$git log 0ac5ad5134f2769ccbaefec73844f8504c4d6182|head -n1 commit 0ac5ad5134f2769ccbaefec73844f8504c4d6182 -- Jim Nasby, Data Architect, Blue Treble Consulting Data in Trouble? Get it in Treble! http://BlueTreble.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Jim Nasby wrote: > Details below, but http://git.postgresql.org/gitweb/?p=postgresql.git&a=search&h=HEAD&st=commit&s=0ac5ad5134f2769ccbaefec73844f8504c4d6182 showsnothing, but that commit does exist: > > decibel@decina:[15:12]~/pgsql/HEAD/src/backend (master=)$git log 0ac5ad5134f2769ccbaefec73844f8504c4d6182|head -n1 > commit 0ac5ad5134f2769ccbaefec73844f8504c4d6182 > > Our github mirror doesn't show that commit in it's search either :( No idea what "search" does, but it doesn't work on a commit ID. This works: http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=0ac5ad5134f2769ccbaefec73844f8504c4d6182 -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
On 11/11/14, 3:55 PM, Alvaro Herrera wrote: > Jim Nasby wrote: >> Details below, but http://git.postgresql.org/gitweb/?p=postgresql.git&a=search&h=HEAD&st=commit&s=0ac5ad5134f2769ccbaefec73844f8504c4d6182 showsnothing, but that commit does exist: >> >> decibel@decina:[15:12]~/pgsql/HEAD/src/backend (master=)$git log 0ac5ad5134f2769ccbaefec73844f8504c4d6182|head -n1 >> commit 0ac5ad5134f2769ccbaefec73844f8504c4d6182 >> >> Our github mirror doesn't show that commit in it's search either :( > > No idea what "search" does, but it doesn't work on a commit ID. This > works: > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=0ac5ad5134f2769ccbaefec73844f8504c4d6182 Well, this is rather confusing, because the drop-down by the search box on [1] has a selection for "commit". You'd thinkthat would allow you to search for a specific commit. Turns out, the help [2] states that the "commit" context for search searches commit author and messages. So I guess it'sas expected, albeit confusing. :( Anyone know how hard it would be to allow a commit "search" to also look for a specific commit hash? 1: http://git.postgresql.org/gitweb/?p=postgresql.git;a=summary 2: http://git.postgresql.org/gitweb/?p=postgresql.git;a=search_help -- Jim Nasby, Data Architect, Blue Treble Consulting Data in Trouble? Get it in Treble! http://BlueTreble.com
On Wed, Nov 12, 2014 at 12:08 AM, Jim Nasby <Jim.Nasby@bluetreble.com> wrote: > On 11/11/14, 3:55 PM, Alvaro Herrera wrote: >> >> Jim Nasby wrote: >>> >>> Details below, but >>> http://git.postgresql.org/gitweb/?p=postgresql.git&a=search&h=HEAD&st=commit&s=0ac5ad5134f2769ccbaefec73844f8504c4d6182 >>> shows nothing, but that commit does exist: >>> >>> decibel@decina:[15:12]~/pgsql/HEAD/src/backend (master=)$git log >>> 0ac5ad5134f2769ccbaefec73844f8504c4d6182|head -n1 >>> commit 0ac5ad5134f2769ccbaefec73844f8504c4d6182 >>> >>> Our github mirror doesn't show that commit in it's search either :( >> >> >> No idea what "search" does, but it doesn't work on a commit ID. This >> works: >> >> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=0ac5ad5134f2769ccbaefec73844f8504c4d6182 > > > Well, this is rather confusing, because the drop-down by the search box on > [1] has a selection for "commit". You'd think that would allow you to search > for a specific commit. > > Turns out, the help [2] states that the "commit" context for search searches > commit author and messages. So I guess it's as expected, albeit confusing. > :( > > Anyone know how hard it would be to allow a commit "search" to also look for > a specific commit hash? Preferably submit it for inclusion *upstream* as a feature. We'd rather not end up forking gitweb. (And while at it, feel free to fix it to be less super-slow :P) -- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/