Postgres Pro
Downloads
Home   >   mailing lists

Thread: RE: [SQL] Column name's length

RE: [SQL] Column name's length

From
"Pham, Thinh"
Date:
Is there any reason you made OIDNAMELEN 260 instead of 256? Also, should i
wait until 6.5 came out before trying to fix this thing? Since it looks like
it's not going to be fixed in 6.5 either. I don't want to dump/reload this
thing too many times since it stores a lot of other more critical data
besides this timeclock thing. I saw the postgres website mentioned that 6.5
is coming out in around one week, is that true?
Thinh


> -----
> diff  postgresql-6.4.2/src/include/postgres_ext.h 
> postgres-build/src/include/postgres_ext.h
> 34c34
> < #define NAMEDATALEN 32
> ---
> > #define NAMEDATALEN 256
> 37c37
> < #define OIDNAMELEN    36
> ---
> > #define OIDNAMELEN    260
> -----
> diff postgresql-6.4.2/src/include/storage/buf_internals.h 
> postgres-build/src/include/storage/buf_internals.h
> 87c87
> < #define PADDED_SBUFDESC_SIZE  128
> ---
> > #define PADDED_SBUFDESC_SIZE  1024
> -----

Re: [SQL] Column name's length

From
Bruce Momjian
Date:
[Charset iso-8859-1 unsupported, filtering to ASCII...]
> Is there any reason you made OIDNAMELEN 260 instead of 256? Also, should i
> wait until 6.5 came out before trying to fix this thing? Since it looks like
> it's not going to be fixed in 6.5 either. I don't want to dump/reload this
> thing too many times since it stores a lot of other more critical data
> besides this timeclock thing. I saw the postgres website mentioned that 6.5
> is coming out in around one week, is that true?
> Thinh

It has to be 260 if NAMEDATALEN is 256:

/* OIDNAMELEN should be set to NAMEDATALEN + sizeof(Oid) */
#define OIDNAMELEN  36

6.5 is scheduled for June 7.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026