Thread: Patch reviewers
Guys, I'm in for the glory of reviewing patches (special thanks to David Fetter on paying me with a brand new BMW for reviewing) Any other spanish speaking patch reviewer around? gb.-
2010/10/1 ๏̯͡๏ Guido Barosio <gbarosio@gmail.com>: > Guys, I'm in for the glory of reviewing patches (special thanks to > David Fetter on paying me with a brand new BMW for reviewing) > > Any other spanish speaking patch reviewer around? > me from time to time and Alvaro that is a committer... why David is paying you with a BMW? i want the same thing... i think i will promote a strike of rrreviewers (so Ecuadorian ;) -- Jaime Casanova www.2ndQuadrant.com Soporte y capacitación de PostgreSQL
Great, good to know :) I've already translated the Patch review process page, and I have it available where it belongs: our wiki http://wiki.postgresql.org/wiki/Como_colaborar_con_PostgreSQL:_Revisi%C3%B3n_de_Patches The text has been translated but I am missing some styling and links that appear in the original document. Can I have an extra pair of eyes on this? Fetter chased me on getting some latin american hands for the review process. So I thought about that translating the page as a first step and here we are. Thoughts? gb.- 2010/10/1 Jaime Casanova <jaime@2ndquadrant.com>: > 2010/10/1 ๏̯͡๏ Guido Barosio <gbarosio@gmail.com>: >> Guys, I'm in for the glory of reviewing patches (special thanks to >> David Fetter on paying me with a brand new BMW for reviewing) >> >> Any other spanish speaking patch reviewer around? >> > > me from time to time and Alvaro that is a committer... why David is > paying you with a BMW? i want the same thing... > i think i will promote a strike of rrreviewers (so Ecuadorian ;) > > -- > Jaime Casanova www.2ndQuadrant.com > Soporte y capacitación de PostgreSQL >
On Fri, Oct 01, 2010 at 03:42:54PM -0500, Jaime Casanova wrote: > 2010/10/1 ๏̯͡๏ Guido Barosio <gbarosio@gmail.com>: > > Guys, I'm in for the glory of reviewing patches (special thanks to > > David Fetter on paying me with a brand new BMW for reviewing) > > > > Any other spanish speaking patch reviewer around? > > me from time to time and Alvaro that is a committer... why David is > paying you with a BMW? i want the same thing... i think i will > promote a strike of rrreviewers (so Ecuadorian ;) I will give you twice as many BMWs as I give Guido ;) Cheers, David. -- David Fetter <david@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
On Fri, Oct 1, 2010 at 4:30 PM, David Fetter <david@fetter.org> wrote: > > I will give you twice as many BMWs as I give Guido ;) > fair enough, you have my vote... btw, this week i started reviewing the fix snapshot inconsistencies patch i will send a review this weekend -- Jaime Casanova www.2ndQuadrant.com Soporte y capacitación de PostgreSQL
On Fri, Oct 01, 2010 at 05:40:04PM -0500, Jaime Casanova wrote: > On Fri, Oct 1, 2010 at 4:30 PM, David Fetter <david@fetter.org> wrote: > > I will give you twice as many BMWs as I give Guido ;) > > fair enough, you have my vote... btw, this week i started reviewing > the fix snapshot inconsistencies patch i will send a review this > weekend Excellent! As always, when you're reviewing a patch, add yourself as a reviewer and put in a comment. Cheers, David. -- David Fetter <david@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
๏̯͡๏ Guido Barosio wrote: > I've already translated the Patch review process page, and I have it > available where it belongs: our wiki > > http://wiki.postgresql.org/wiki/Como_colaborar_con_PostgreSQL:_Revisi%C3%B3n_de_Patches > > The text has been translated but I am missing some styling and links > that appear in the original document. Can I have an extra pair of eyes > on this? > This is all fixed now, but it's at a new URL: http://wiki.postgresql.org/wiki/Reviewing_a_Patch/es Note that you if you visit the English http://wiki.postgresql.org/wiki/Reviewing_a_Patch , you'll see a link to the Spanish one. In order for that all to work, the translated version must have the exact same name as the original, followed by a slash and the country code. See http://wiki.postgresql.org/wiki/Template:Languages for a list of valid country codes. If you want to translate another page like this, here is what I would recommend doing: 1) Look at the English version 2) Click on "Edit" 3) Copy all of the text in that version to your clipboard 4) Create a new page using the naming suggested above (English named followed by /es for all Spanish ones). 5) Paste the original text in. This will get you all of the hyperlinks and the formatting. 6) Translate the text section at a time. 7) At the top, add something that looks like this: {{Languages|Reviewing a Patch}} Where the name of the English version is used, to say what this is a translation of. I just wrote a summary of the above at a new page named http://wiki.postgresql.org/wiki/PostgreSQL_Wiki:Language_policy In addition to the hyperlinks being missing, there were also two forms of formatting issue with the one you did that you'd have avoided if you followed this approach: A) The section headers in the original were marked with "==", the ones you did weren't B) You made the lists by pasting in a bullet character and then adding <br> to the end of each line. If you just start each list line with "*" instead, you don't have to do all that. It only took me a few minutes to clean this all up so no problem for me, it's just that this would have made things easier for you--no need to do all that <br> stuff for example. -- Greg Smith, 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD PostgreSQL Training, Services and Support www.2ndQuadrant.us Author, "PostgreSQL 9.0 High Performance" Pre-ordering at: https://www.packtpub.com/postgresql-9-0-high-performance/book
Cheers Greg, many thanks :) Gb.- 2010/10/1, Greg Smith <greg@2ndquadrant.com>: > ๏̯͡๏ Guido Barosio wrote: >> I've already translated the Patch review process page, and I have it >> available where it belongs: our wiki >> >> http://wiki.postgresql.org/wiki/Como_colaborar_con_PostgreSQL:_Revisi%C3%B3n_de_Patches >> >> The text has been translated but I am missing some styling and links >> that appear in the original document. Can I have an extra pair of eyes >> on this? >> > > This is all fixed now, but it's at a new URL: > http://wiki.postgresql.org/wiki/Reviewing_a_Patch/es > > Note that you if you visit the English > http://wiki.postgresql.org/wiki/Reviewing_a_Patch , you'll see a link to > the Spanish one. In order for that all to work, the translated version > must have the exact same name as the original, followed by a slash and > the country code. See > http://wiki.postgresql.org/wiki/Template:Languages for a list of valid > country codes. > > If you want to translate another page like this, here is what I would > recommend doing: > > 1) Look at the English version > 2) Click on "Edit" > 3) Copy all of the text in that version to your clipboard > 4) Create a new page using the naming suggested above (English named > followed by /es for all Spanish ones). > 5) Paste the original text in. This will get you all of the hyperlinks > and the formatting. > 6) Translate the text section at a time. > 7) At the top, add something that looks like this: > > {{Languages|Reviewing a Patch}} > > Where the name of the English version is used, to say what this is a > translation of. I just wrote a summary of the above at a new page > named http://wiki.postgresql.org/wiki/PostgreSQL_Wiki:Language_policy > > In addition to the hyperlinks being missing, there were also two forms > of formatting issue with the one you did that you'd have avoided if you > followed this approach: > > A) The section headers in the original were marked with "==", the ones > you did weren't > B) You made the lists by pasting in a bullet character and then adding > <br> to the end of each line. If you just start each list line with "*" > instead, you don't have to do all that. > > It only took me a few minutes to clean this all up so no problem for me, > it's just that this would have made things easier for you--no need to do > all that <br> stuff for example. > > -- > Greg Smith, 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD > PostgreSQL Training, Services and Support www.2ndQuadrant.us > Author, "PostgreSQL 9.0 High Performance" Pre-ordering at: > https://www.packtpub.com/postgresql-9-0-high-performance/book > > -- Enviado desde mi dispositivo móvil