Postgres Pro
Downloads
Home   >   mailing lists

Thread: Make 2PC error messages match docs

Make 2PC error messages match docs

From
Steve Woodcock
Date:
Hi,

This makes the error messages for PREPARE TRANSACTION, COMMIT PREPARED
etc. match the docs, which talk about "transaction identifier" not
"gid" or "global transaction identifier".

Regards, Steve Woodcock
Attachment

Re: Make 2PC error messages match docs

From
Bruce Momjian
Date:
Steve Woodcock wrote:
> Hi,
>
> This makes the error messages for PREPARE TRANSACTION, COMMIT PREPARED
> etc. match the docs, which talk about "transaction identifier" not
> "gid" or "global transaction identifier".

Agreed.  However, haven't we frozen the error strings?  This arrived
October 2 when I think the change could have been made, but now, can we?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: Make 2PC error messages match docs

From
Tom Lane
Date:
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Steve Woodcock wrote:
>> This makes the error messages for PREPARE TRANSACTION, COMMIT PREPARED
>> etc. match the docs, which talk about "transaction identifier" not
>> "gid" or "global transaction identifier".

> Agreed.  However, haven't we frozen the error strings?  This arrived
> October 2 when I think the change could have been made, but now, can we?

Peter has been editorializing on the messages over the past week or two
(I assume when he comes across something he doesn't like while translating),
so the freeze doesn't seem that hard to me.  I'm fine with that patch.
Peter, what's your opinion?

            regards, tom lane

Re: Make 2PC error messages match docs

From
Bruce Momjian
Date:
Patch applied.  Thanks.

---------------------------------------------------------------------------


Steve Woodcock wrote:
> Hi,
>
> This makes the error messages for PREPARE TRANSACTION, COMMIT PREPARED
> etc. match the docs, which talk about "transaction identifier" not
> "gid" or "global transaction identifier".
>
> Regards, Steve Woodcock

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073