Thread: Re: [pgsql-hackers-win32] VC++ psql build broken

Re: [pgsql-hackers-win32] VC++ psql build broken

From
"Dave Page"
Date:

> -----Original Message-----
> From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
> Sent: 12 September 2004 14:59
> To: Dave Page
> Cc: PgSQL Win32 developers; PostgreSQL Patches
> Subject: Re: [pgsql-hackers-win32] VC++ psql build broken
>
>
> How does your Win32 system rename prototype differ from what
> is in port.h?
>
>     extern int  pgrename(const char *from, const char *to);

_CRTIMP int __cdecl rename(const char *, const char *);


>     extern int  pgunlink(const char *path);

_CRTIMP int __cdecl _unlink(const char *);

> Good question on wether we need to keep this working but it
> would be nice to keep it I guess for client-only installs
> that want to build from source using non-Mingw.

Nice, but not essential. I certainly don't think it's worth spending
excessive amounts of energy on though.

Regards, Dave

Re: [pgsql-hackers-win32] VC++ psql build broken

From
Bruce Momjian
Date:
I have fixed this issue with Dave's help.

---------------------------------------------------------------------------

Dave Page wrote:
>
>
> > -----Original Message-----
> > From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
> > Sent: 12 September 2004 14:59
> > To: Dave Page
> > Cc: PgSQL Win32 developers; PostgreSQL Patches
> > Subject: Re: [pgsql-hackers-win32] VC++ psql build broken
> >
> >
> > How does your Win32 system rename prototype differ from what
> > is in port.h?
> >
> >     extern int  pgrename(const char *from, const char *to);
>
> _CRTIMP int __cdecl rename(const char *, const char *);
>
>
> >     extern int  pgunlink(const char *path);
>
> _CRTIMP int __cdecl _unlink(const char *);
>
> > Good question on wether we need to keep this working but it
> > would be nice to keep it I guess for client-only installs
> > that want to build from source using non-Mingw.
>
> Nice, but not essential. I certainly don't think it's worth spending
> excessive amounts of energy on though.
>
> Regards, Dave
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073