Thread: Re: [BUGS] BUG #1219: pgxs does not work fully
Please find enclose a submission to fix these problems. The patch adds missing the "libpgport.a" file to the installation under "install-all-headers". It is needed by some contribs. I install the library in "pkglibdir", but I was wondering whether it should be "libdir"? I was wondering also whether it would make sense to have a "libpgport.so"? It fixes various macros which are used by contrib makefiles, especially libpq_*dir and LDFLAGS when used under PGXS. It seems to me that they are needed to It adds the ability to test and use PGXS with contribs, with "make USE_PGXS=1". Without the macro, this is exactly as before, there should be no difference, esp. wrt the vpath feature that seemed broken by previous submission. So it should not harm anybody, and it is useful at least to me. It fixes some inconsistencies in various contrib makefiles (useless override, ":=" instead of "="). It works for me. it validates. I'm available to fix any problem with this patch. Have a nice day, -- Fabien Coelho - coelho@cri.ensmp.fr
Attachment
Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO: > The patch adds missing the "libpgport.a" file to the installation under > "install-all-headers". It is needed by some contribs. I install the > library in "pkglibdir", but I was wondering whether it should be "libdir"? Yes it should. Please change it. -- Peter Eisentraut http://developer.postgresql.org/~petere/
> Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO: > > The patch adds missing the "libpgport.a" file to the installation under > > "install-all-headers". It is needed by some contribs. I install the > > library in "pkglibdir", but I was wondering whether it should be "libdir"? > > Yes it should. Please change it. Dear Peter, dear patchers, Please find attached a small patch against current CVS head that fixes pgport library installation so that it goes to libdir instead of pkglibdir. It works for me. Have a nice day, -- Fabien Coelho - coelho@cri.ensmp.fr
Attachment
Patch applied. Thanks. --------------------------------------------------------------------------- Fabien COELHO wrote: > > > Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO: > > > The patch adds missing the "libpgport.a" file to the installation under > > > "install-all-headers". It is needed by some contribs. I install the > > > library in "pkglibdir", but I was wondering whether it should be "libdir"? > > > > Yes it should. Please change it. > > Dear Peter, dear patchers, > > Please find attached a small patch against current CVS head that fixes > pgport library installation so that it goes to libdir instead of > pkglibdir. It works for me. > > Have a nice day, > > -- > Fabien Coelho - coelho@cri.ensmp.fr Content-Description: [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073