Thread: Re: [ODBC] UI patch (Was: ODBC Patch to prevent setting of KSQO on 7.3+ servers)

> -----Original Message-----
> From: Hiroshi Inoue [mailto:Inoue@tpf.co.jp]
> Sent: 04 July 2002 04:15
> To: Dave Page
> Cc: pgsql-odbc@postgresql.org; pgsql-patches@postgresql.org
> Subject: Re: [ODBC] ODBC Patch to prevent setting of KSQO on
> 7.3+ servers
>
> > I can either figure out the differences and manually sort it, or we
> > could get rid of the non-multibyte version (we don't ship
> it anymore
> > anyway, as we agreed some time ago).
> >
> > Which do you prefer?
>
> Sorry for the late answer.
> According to Eiji Tokuya, we had better adopt the
> multibyte version of resource if we would only ship
> with the multibyte version of driver.

OK, I've attached a new version. In actual fact, I could find no
differences between the mb/non-mb dialogs other than the layout - is
that right, or did I miss something subtle?

The attached patch also updates notice.txt to reflect Eiji's work, and
sets the company name in the dll version resource to 'The PostgreSQL
Global Development Group' to match the rest of PostgreSQL.

Some of my other comments also still apply to this version of the patch:

1) There is no default button on DLG_OPTIONS_DS - I have left space for
one but didn't know how to plumb it in (sorry, I don't have time to
figure it out now).

2) Each time DLG_OPTIONS_DS or DLG_OPTIONS_DRV are opened by pressing
the Page 1/2 buttons, they move progressively further down the screen as
well as a little to the right.

3) I looked briefly at using a tabset instead of 2 dialogues, however I
couldn't figure it out in the time I had spare. Does anyone else know we
do this?

Regards, Dave.

> -----Original Message-----
> From: Dave Page [mailto:dpage@vale-housing.co.uk]
> > -----Original Message-----
> > From: Hiroshi Inoue [mailto:Inoue@tpf.co.jp]
> >
> > > I can either figure out the differences and manually sort it, or we
> > > could get rid of the non-multibyte version (we don't ship
> > it anymore
> > > anyway, as we agreed some time ago).
> > >
> > > Which do you prefer?
> >
> > Sorry for the late answer.
> > According to Eiji Tokuya, we had better adopt the
> > multibyte version of resource if we would only ship
> > with the multibyte version of driver.
>
> OK, I've attached a new version. In actual fact, I could find no
> differences between the mb/non-mb dialogs other than the layout - is
> that right, or did I miss something subtle?

The font "Terminal" seems better than "MS Sans Serif".
Multibyte input to e.g. "Description"  may not be handled
properly with "MS Sans Serif". Eiji used FONT 10, "Terminal"
in multibyte mode.

regards,
Hiroshi Inoue

Dave Page wrote:
>
> > -----Original Message-----
> > From: Hiroshi Inoue [mailto:Inoue@tpf.co.jp]
> > Sent: 04 July 2002 04:15
> > To: Dave Page
> > Cc: pgsql-odbc@postgresql.org; pgsql-patches@postgresql.org
> > Subject: Re: [ODBC] ODBC Patch to prevent setting of KSQO on
> > 7.3+ servers
> >
> > > I can either figure out the differences and manually sort it, or we
> > > could get rid of the non-multibyte version (we don't ship
> > it anymore
> > > anyway, as we agreed some time ago).
> > >
> > > Which do you prefer?
> >
> > Sorry for the late answer.
> > According to Eiji Tokuya, we had better adopt the
> > multibyte version of resource if we would only ship
> > with the multibyte version of driver.
>
> OK, I've attached a new version. In actual fact, I could find no
> differences between the mb/non-mb dialogs other than the layout - is
> that right, or did I miss something subtle?

I've just committed you change after changing the FONT.
Please check it.
I seem to have committed all the changes for 7.2.0.2.

regards,
Hiroshi Inoue
    http://w2422.nsk.ne.jp/~inoue/