Thread: useless statements in parse_datestyle_internal

useless statements in parse_datestyle_internal

From
Yury Bokhoncovich
Date:
Hello!

obvious thing.

=======================
--- src/backend/commands/variable.c.orig        Wed Mar 20 15:25:07 2002
+++ src/backend/commands/variable.c.new Wed Mar 20 17:33:45 2002
@@ -223,8 +223,6 @@
                        DateStyle = USE_GERMAN_DATES;
                        dcnt++;
                        EuroDates = TRUE;
-                       if ((ecnt > 0) && (!EuroDates))
-                               ecnt++;
                }
                else if (!strncasecmp(tok, "EURO", 4))
                {
=======================

--
WBR, Yury Bokhoncovich, Senior System Administrator, NOC of F1 Group.
Phone: +7 (3832) 106228, ext.140, E-mail: byg@center-f1.ru.
Unix is like a wigwam -- no Gates, no Windows, and an Apache inside.



Re: useless statements in parse_datestyle_internal

From
Thomas Lockhart
Date:
> =======================
> --- src/backend/commands/variable.c.orig        Wed Mar 20 15:25:07 2002
> +++ src/backend/commands/variable.c.new Wed Mar 20 17:33:45 2002
> @@ -223,8 +223,6 @@
>                         DateStyle = USE_GERMAN_DATES;
>                         dcnt++;
>                         EuroDates = TRUE;
> -                       if ((ecnt > 0) && (!EuroDates))
> -                               ecnt++;
>                 }
>                 else if (!strncasecmp(tok, "EURO", 4))
>                 {

Thanks Yury. I'll fix it by moving the EuroDates = TRUE down below the
check on ecnt and EuroDates, rather than removing the check. But you're
right, the code as-is doesn't do much useful :)

                   - Thomas