Re: useless statements in parse_datestyle_internal - Mailing list pgsql-patches

From Thomas Lockhart
Subject Re: useless statements in parse_datestyle_internal
Date
Msg-id 3C98A3FA.98D1A05C@fourpalms.org
Whole thread Raw
In response to useless statements in parse_datestyle_internal  (Yury Bokhoncovich <byg@center-f1.ru>)
List pgsql-patches
> =======================
> --- src/backend/commands/variable.c.orig        Wed Mar 20 15:25:07 2002
> +++ src/backend/commands/variable.c.new Wed Mar 20 17:33:45 2002
> @@ -223,8 +223,6 @@
>                         DateStyle = USE_GERMAN_DATES;
>                         dcnt++;
>                         EuroDates = TRUE;
> -                       if ((ecnt > 0) && (!EuroDates))
> -                               ecnt++;
>                 }
>                 else if (!strncasecmp(tok, "EURO", 4))
>                 {

Thanks Yury. I'll fix it by moving the EuroDates = TRUE down below the
check on ecnt and EuroDates, rather than removing the check. But you're
right, the code as-is doesn't do much useful :)

                   - Thomas

pgsql-patches by date:

Previous
From: Yury Bokhoncovich
Date:
Subject: useless statements in parse_datestyle_internal
Next
From: Tom Lane
Date:
Subject: Re: Eurodates by default