Thread: Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)

> > > 3 out of 3 hunks FAILED -- saving rejects to file
src/include/c.h.rej
> >
> > My guess is that pgindent has modified c.h.  Tatsuo, if you send me
the
> > patch, I will manually apply it to current CVS and send you a new
> > version of the patch for testing.
>
> OK, Tatsuo, here is an updated version for testing.  It initdb and
> regression tests fine on my BSD/OS machine.

Bruce, you take me off the cc: and expect me to test (i am not on
patches).
Your Patch does not work here.

Please test the one I sent in previously. The problem with yours is,
that AIX (at least 4.3.3 and below) does not typedef the unsigned types.
But your patch assumes, that checking int64 is sufficient for uint64.

BEOS has both signed and unsigned, thus my patch should satisfy both.

Thanks
Andreas

> > OK, Tatsuo, here is an updated version for testing.  It initdb and
> > regression tests fine on my BSD/OS machine.
>
> Bruce, you take me off the cc: and expect me to test (i am not on
> patches).

Oh.  I accidentally deleted the email thread so I head to email a new
message.  I couldn't figure out how to see the CC line in
fts.postgresql.org archives.

> Your Patch does not work here.
>
> Please test the one I sent in previously. The problem with yours is,
> that AIX (at least 4.3.3 and below) does not typedef the unsigned types.
> But your patch assumes, that checking int64 is sufficient for uint64.
>
> BEOS has both signed and unsigned, thus my patch should satisfy both.

OK, we package beta3 tomorrow.  I am going to apply the patch now so
people can test it more easily and maybe we will see any problem reports
before tomorrow.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026