Thread: ECPG patches: get descriptor NULL alloc, external names

ECPG patches: get descriptor NULL alloc, external names

From
Christof Petig
Date:
Hi Michael,

these patches fix the following issues with libecpg:

1)
- get descriptor didn't allocate memory if passed a NULL pointer
- now get descriptor shares code with ECPGexecute regarding storage in
output variables
- some code cleanup, recognize timestamp without timezone

2)
- make all external visible names of libecpg start with ECPG (without
changing ecpg_*)

3)
- rename ecpg_* to ECPG* to make the visible names look more homogenous

These address the last outstanding issues I had for 7.2.

    Christof

PS: If these patches do not apply cleanly to current sources, please
tell me, I'll redo them.
PPS: The first patch requires the patch (char**=0) I sent in last week
(still unapplied)


Attachment

Re: ECPG patches: get descriptor NULL alloc, external names

From
Bruce Momjian
Date:
Your patch has been added to the PostgreSQL unapplied patches list at:

    http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Christof Petig wrote:
> Hi Michael,
>
> these patches fix the following issues with libecpg:
>
> 1)
> - get descriptor didn't allocate memory if passed a NULL pointer
> - now get descriptor shares code with ECPGexecute regarding storage in
> output variables
> - some code cleanup, recognize timestamp without timezone
>
> 2)
> - make all external visible names of libecpg start with ECPG (without
> changing ecpg_*)
>
> 3)
> - rename ecpg_* to ECPG* to make the visible names look more homogenous
>
> These address the last outstanding issues I had for 7.2.
>
>     Christof
>
> PS: If these patches do not apply cleanly to current sources, please
> tell me, I'll redo them.
> PPS: The first patch requires the patch (char**=0) I sent in last week
> (still unapplied)
>

[ application/x-gzip is not supported, skipping... ]

[ application/x-gzip is not supported, skipping... ]

[ application/x-gzip is not supported, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: ECPG patches: get descriptor NULL alloc, external names

From
Bruce Momjian
Date:
I am told this was already added to 7.2.  Thanks.

---------------------------------------------------------------------------

Christof Petig wrote:
> Hi Michael,
>
> these patches fix the following issues with libecpg:
>
> 1)
> - get descriptor didn't allocate memory if passed a NULL pointer
> - now get descriptor shares code with ECPGexecute regarding storage in
> output variables
> - some code cleanup, recognize timestamp without timezone
>
> 2)
> - make all external visible names of libecpg start with ECPG (without
> changing ecpg_*)
>
> 3)
> - rename ecpg_* to ECPG* to make the visible names look more homogenous
>
> These address the last outstanding issues I had for 7.2.
>
>     Christof
>
> PS: If these patches do not apply cleanly to current sources, please
> tell me, I'll redo them.
> PPS: The first patch requires the patch (char**=0) I sent in last week
> (still unapplied)
>

[ application/x-gzip is not supported, skipping... ]

[ application/x-gzip is not supported, skipping... ]

[ application/x-gzip is not supported, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026