Thread: Re: [JDBC] Patch for jdbc2 ResultSet.java
Dave Harkness wrote: > At 12:41 PM 9/5/2001, Joseph Shraibman wrote: > >> new patch: > > > There still seems to be an error with the same if-block. > > ! if (index>=-rows.size()) > ! internalIndex=rows.size()+index; > > becomes > > ! if (index > -rows_size) > ! internalIndex = rows_size+index; > > Note that the original used >=, not >. Argh! I need a better screen. :( > > Also, why is the first edit being done? Granted it's faster in that it > doesn't null out the array of rows, but won't that have other effects? No. Nulling out the array is pointless. -- Joseph Shraibman jks@selectacast.net Increase signal to noise ratio. http://www.targabot.com
Can I have a new version of this for application? > > > Dave Harkness wrote: > > At 12:41 PM 9/5/2001, Joseph Shraibman wrote: > > > >> new patch: > > > > > > There still seems to be an error with the same if-block. > > > > ! if (index>=-rows.size()) > > ! internalIndex=rows.size()+index; > > > > becomes > > > > ! if (index > -rows_size) > > ! internalIndex = rows_size+index; > > > > Note that the original used >=, not >. > > Argh! I need a better screen. :( > > > > Also, why is the first edit being done? Granted it's faster in that it > > doesn't null out the array of rows, but won't that have other effects? > > No. Nulling out the array is pointless. > > > > > -- > Joseph Shraibman > jks@selectacast.net > Increase signal to noise ratio. http://www.targabot.com > > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Sorry, I see it now. > > > Dave Harkness wrote: > > At 12:41 PM 9/5/2001, Joseph Shraibman wrote: > > > >> new patch: > > > > > > There still seems to be an error with the same if-block. > > > > ! if (index>=-rows.size()) > > ! internalIndex=rows.size()+index; > > > > becomes > > > > ! if (index > -rows_size) > > ! internalIndex = rows_size+index; > > > > Note that the original used >=, not >. > > Argh! I need a better screen. :( > > > > Also, why is the first edit being done? Granted it's faster in that it > > doesn't null out the array of rows, but won't that have other effects? > > No. Nulling out the array is pointless. > > > > > -- > Joseph Shraibman > jks@selectacast.net > Increase signal to noise ratio. http://www.targabot.com > > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026