Postgres Pro
Downloads
Home   >   mailing lists

Thread: to_char's ISO week

to_char's ISO week

From
Karel Zak
Date:
 * to_char:

  - full support for IW (ISO week) and vice versa conversion for IW too
    (the to_char 'week' support is now complete and I hope correct).

  Thomas, I use for IW code from timestamp.c, for this I create separate
  function date2isoweek() from original 'case DTK_WEEK:' code in the
  timestamp_part(). I mean will better use one code for same feature in
  date_part() and in to_char(). The isoweek2date() is added to timestamp.c
  too. Right?

  IMHO in 7.1 will all to_char's features complete. It is cca 41 templates
  for date/time and cca 21 for numbers.

 * to_ascii:

   - gcc, is it correct now? :-)


  In the patch is documentation for to_char's IW and for to_ascii().

                            Karel
Attachment

Re: to_char's ISO week

From
Karel Zak
Date:
> Thanks! I'll look at it and apply it asap (hopefully by tomorrow).

 I Thanks too.

        Karel

Re: to_char's ISO week

From
Bruce Momjian
Date:
Applied, except for the following.  The C files had 'return 0' and I
left those unchanged.

---------------------------------------------------------------------------

***************
*** 38,55 ****
  to_ascii_encname(PG_FUNCTION_ARGS)
  {
      multibyte_error();
  }

  Datum
  to_ascii_enc(PG_FUNCTION_ARGS)
  {
      multibyte_error();
  }

  Datum
  to_ascii_default(PG_FUNCTION_ARGS)
  {
      multibyte_error();
  }


--- 38,58 ----
  to_ascii_encname(PG_FUNCTION_ARGS)
  {
      multibyte_error();
+     return (Datum) NULL;
  }

  Datum
  to_ascii_enc(PG_FUNCTION_ARGS)
  {
      multibyte_error();
+     return (Datum) NULL;
  }

  Datum
  to_ascii_default(PG_FUNCTION_ARGS)
  {
      multibyte_error();
+     return (Datum) NULL;
  }


>
>  * to_char:
>
>   - full support for IW (ISO week) and vice versa conversion for IW too
>     (the to_char 'week' support is now complete and I hope correct).
>
>   Thomas, I use for IW code from timestamp.c, for this I create separate
>   function date2isoweek() from original 'case DTK_WEEK:' code in the
>   timestamp_part(). I mean will better use one code for same feature in
>   date_part() and in to_char(). The isoweek2date() is added to timestamp.c
>   too. Right?
>
>   IMHO in 7.1 will all to_char's features complete. It is cca 41 templates
>   for date/time and cca 21 for numbers.
>
>  * to_ascii:
>
>    - gcc, is it correct now? :-)
>
>
>   In the patch is documentation for to_char's IW and for to_ascii().
>
>                             Karel
Content-Description:

[ application/x-gzip is not supported, skipping... ]


--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: to_char's ISO week

From
Karel Zak
Date:
On Tue, 29 Aug 2000, Bruce Momjian wrote:

> Applied, except for the following.  The C files had 'return 0' and I
> left those unchanged.

 Bruce, thanks for your "keep compiler quiet" options. It's good.


 While I'm writing....  Tom (Lane), plan you add to aset.c matter for
make from block-residual-space free chunks? If I good remenber, you said
that you take care of it. I can again send this old patch.

            Karel