Thread: to_date/char (fwd)

to_date/char (fwd)

From
Karel Zak
Date:

 I'm sending this letter again (and directly to you Bruce), first time I sent
it on Wednesday, but patches list is still quiet --- but I'm not tease, the
patches-list is decent, today I hear "welcome message.." from this :-)

--

 In the attache is new to_date()/to_timestamp() version.

 Now the to_timestamp() support WW,W,J,SSSS,DDD conversion from strings and
the am/pm bug is fixed, the to_char() use week-of-year (WW) full compatible
with Oracle.

 This patch update relevant regress-tests and docs too.

                    Karel

Attachment

Re: to_date/char (fwd)

From
Bruce Momjian
Date:
Applied.

>
>
>  I'm sending this letter again (and directly to you Bruce), first time I sent
> it on Wednesday, but patches list is still quiet --- but I'm not tease, the
> patches-list is decent, today I hear "welcome message.." from this :-)
>
> --
>
>  In the attache is new to_date()/to_timestamp() version.
>
>  Now the to_timestamp() support WW,W,J,SSSS,DDD conversion from strings and
> the am/pm bug is fixed, the to_char() use week-of-year (WW) full compatible
> with Oracle.
>
>  This patch update relevant regress-tests and docs too.
>
>                     Karel
Content-Description:

[ application/X-GZIP is not supported, skipping... ]


--
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: to_date/char (fwd)

From
Peter Eisentraut
Date:
Karel Zak writes:

> the to_char() use week-of-year (WW) full compatible with Oracle.

Not compatible with reality (and standards) though. Any plans to do
something about that?


--
Peter Eisentraut                  Sernanders väg 10:115
peter_e@gmx.net                   75262 Uppsala
http://yi.org/peter-e/            Sweden


Re: to_date/char (fwd)

From
Bruce Momjian
Date:
I am backing out the patch.  It does not compile on the current
development tree.

> Applied.
>
> >
> >
> >  I'm sending this letter again (and directly to you Bruce), first time I sent
> > it on Wednesday, but patches list is still quiet --- but I'm not tease, the
> > patches-list is decent, today I hear "welcome message.." from this :-)
> >
> > --
> >
> >  In the attache is new to_date()/to_timestamp() version.
> >
> >  Now the to_timestamp() support WW,W,J,SSSS,DDD conversion from strings and
> > the am/pm bug is fixed, the to_char() use week-of-year (WW) full compatible
> > with Oracle.
> >
> >  This patch update relevant regress-tests and docs too.
> >
> >                     Karel
> Content-Description:
>
> [ application/X-GZIP is not supported, skipping... ]
>
>
> --
>   Bruce Momjian                        |  http://www.op.net/~candle
>   pgman@candle.pha.pa.us               |  (610) 853-3000
>   +  If your life is a hard drive,     |  830 Blythe Avenue
>   +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026


--
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: to_date/char (fwd)

From
Bruce Momjian
Date:
[ Charset ISO-8859-1 unsupported, converting... ]
> Karel Zak writes:
>
> > the to_char() use week-of-year (WW) full compatible with Oracle.
>
> Not compatible with reality (and standards) though. Any plans to do
> something about that?

I am backing it out.  It doesn't compile.

--
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: Re: to_date/char (fwd)

From
Tom Lane
Date:
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I am backing out the patch.  It does not compile on the current
> development tree.

I think the problem is that it hasn't been updated for the latest
fmgr-related changes.  It's hard to tell with all the whitespace
changes, but I think Karel must have been working from
formatting.c 1.9 or so.

            regards, tom lane

Re: to_date/char (fwd)

From
Karel Zak
Date:
On Sat, 1 Jul 2000, Peter Eisentraut wrote:

> Karel Zak writes:
>
> > the to_char() use week-of-year (WW) full compatible with Oracle.
>
> Not compatible with reality (and standards) though. Any plans to do
> something about that?

 For standards is better date_part(). But yes, in oracle exist IW (ISO
week), I plan this in later.

                    Karel


correction: Re: Re: to_date/char (fwd)

From
Karel Zak
Date:

On Sat, 1 Jul 2000, Tom Lane wrote:

> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I am backing out the patch.  It does not compile on the current
> > development tree.
>
> I think the problem is that it hasn't been updated for the latest
> fmgr-related changes.  It's hard to tell with all the whitespace
> changes, but I think Karel must have been working from
> formatting.c 1.9 or so.
>

 "the whitespace changes..." --- I can't programming, if source is not nice
for my eyes..

 But yes, Tom is right (as usually :-), I not expect that in the formatting
code is so much activity. Next time will probably good keep track 'cvs log'.

 In the attache is new (correct) version. I add TZ (timezone) support for
to_char() too.

                Karel

Attachment

Re: correction: Re: Re: to_date/char (fwd)

From
Bruce Momjian
Date:
Applied.

>
>
> On Sat, 1 Jul 2000, Tom Lane wrote:
>
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > I am backing out the patch.  It does not compile on the current
> > > development tree.
> >
> > I think the problem is that it hasn't been updated for the latest
> > fmgr-related changes.  It's hard to tell with all the whitespace
> > changes, but I think Karel must have been working from
> > formatting.c 1.9 or so.
> >
>
>  "the whitespace changes..." --- I can't programming, if source is not nice
> for my eyes..
>
>  But yes, Tom is right (as usually :-), I not expect that in the formatting
> code is so much activity. Next time will probably good keep track 'cvs log'.
>
>  In the attache is new (correct) version. I add TZ (timezone) support for
> to_char() too.
>
>                 Karel
Content-Description:

[ application/x-gzip is not supported, skipping... ]


--
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026