Thread: Compilation psqlODBC againist older PgSQL

Compilation psqlODBC againist older PgSQL

From
Ludek Finstrle
Date:
Hello,

  I take a look at compilation againist older version of PgSQL. First
step is PgSQL version 7.4.X and 7.3.X. Here is attached patch but it
needs add

#define PGSQL_VERSION <major number><minor number>

eg.

#degine PGSQL_VERSION 74

into config.h. I'm not compliant with configure. The value for PGSQL_VERSION
could be taken from pg_config --version (output: PostgreSQL 7.4.8).
How can this be doing in Windows environment? Have we more config.h-<version>
files?

Thist patch also remove "return ret" from CC_send_cancel_request as it is
already called from both part of if (few lines above).

Regards

Luf

Attachment

Re: Compilation psqlODBC againist older PgSQL

From
"Dave Page"
Date:

> -----Original Message-----
> From: pgsql-odbc-owner@postgresql.org
> [mailto:pgsql-odbc-owner@postgresql.org] On Behalf Of Ludek Finstrle
> Sent: 03 December 2005 22:48
> To: pgsql-odbc@postgresql.org
> Subject: [ODBC] Compilation psqlODBC againist older PgSQL
>
> Hello,
>
>   I take a look at compilation againist older version of PgSQL. First
> step is PgSQL version 7.4.X and 7.3.X. Here is attached patch but it
> needs add
>
> #define PGSQL_VERSION <major number><minor number>
>
> eg.
>
> #degine PGSQL_VERSION 74
>
> into config.h. I'm not compliant with configure. The value
> for PGSQL_VERSION
> could be taken from pg_config --version (output: PostgreSQL 7.4.8).
> How can this be doing in Windows environment? Have we more
> config.h-<version>
> files?

Hi Luf,

I could probably hack up some code to suck the value out of pg_config,
however there is no way I can think of to do the same thing on Windows.
Because we only require a standard Windows + VC++ enviroment, we don't
have any of the tools like awk that we'd need to get and manipulate the
pg_config output.

Given that a build against 8.1 or 8.0 will work with servers back to at
least 7.2 or so iirc, I really don't think it's worth the pain to try to
support the older libpqs. Anyone insistent that they cannot build
against the newer server, will likely have no problem using an
equivalent vintage of psqlodbc.

Regards, Dave.

Re: Compilation psqlODBC againist older PgSQL

From
Ludek Finstrle
Date:
> I could probably hack up some code to suck the value out of pg_config,
> however there is no way I can think of to do the same thing on Windows.
> Because we only require a standard Windows + VC++ enviroment, we don't
> have any of the tools like awk that we'd need to get and manipulate the
> pg_config output.
>
> Given that a build against 8.1 or 8.0 will work with servers back to at
> least 7.2 or so iirc, I really don't think it's worth the pain to try to
> support the older libpqs. Anyone insistent that they cannot build
> against the newer server, will likely have no problem using an
> equivalent vintage of psqlodbc.

I'm agree with windows port. But I didn't agree with linux. There is
a lot of production servers with older PgSQL. Compilation againist
another version is strenge (at least isn't documented).
Two changes (not big) isn't so big problem.
But you support psqlodbc longer then me so you have last word. I'll
accept it.

Maybe it could be interesting to have list of unsupported patches?

Luf

Re: Compilation psqlODBC againist older PgSQL

From
"Dave Page"
Date:

> -----Original Message-----
> From: Ludek Finstrle [mailto:luf@pzkagis.cz]
> Sent: 04 December 2005 21:18
> To: Dave Page
> Cc: pgsql-odbc@postgresql.org
> Subject: Re: [ODBC] Compilation psqlODBC againist older PgSQL
>
>
> I'm agree with windows port. But I didn't agree with linux. There is
> a lot of production servers with older PgSQL. Compilation againist
> another version is strenge (at least isn't documented).
> Two changes (not big) isn't so big problem.

Well it will require some autoconf work... Leave it with me, I'll try to
look at it tomorrow.

Windows will have to stay at it is though.

Regards, Dave.