Thread: Re: Bug report: NullPointerException from Driver.connect when passed a Properties with non-string values

Dave,

The inclusion of:

if (!url.startsWith("jdbc:postgresql:")) {
             return null;
         }

in the patch yesterday does not appear to have
been necessary because it looks to be checked
in parseURL().

danap.


It's the placement of it that is important. It checks there before it does anything of consequence at all. I left it in parseURL in case there is a path that I wasn't aware of, and it is pretty inconsequential

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca


On Tue, Jan 29, 2013 at 11:54 AM, dmp <danap@ttc-cmc.net> wrote:
Dave,

The inclusion of:

if (!url.startsWith("jdbc:postgresql:")) {
            return null;
        }

in the patch yesterday does not appear to have
been necessary because it looks to be checked
in parseURL().

danap.