Thread: send/receive buffer size
I read a thread somewhere that somebody contributed a patch for adding support of configurable send/receive buffer size. Did it ever commit into master branch? I did not see any commit message about this change for last 12 months.
__________________________
Shijun Kong
This email message and any attachments may contain legally privileged or confidential information intended solely for the use of the individual or entity to whom it is addressed. If the reader of this message is not the intended recipient, you are hereby notified that any reading, dissemination, distribution or copying of this message or its attachments is strictly prohibited. If you have received this message in error, please notify us immediately by telephone, fax or email and delete the message and all attachments to the message. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Investor Analytics LLC.
On Tue, 21 Aug 2012, Shijun Kong wrote: > I read a thread somewhere that somebody contributed a patch for adding support of configurable send/receive buffer size.Did it ever commit into > master branch? I did not see any commit message about this change for last 12 months. I wondered the same last weekend and found that the patch had NOT yet found its way into pgjdbc on github. In case it helps you, I've attached that old patch in a form that should apply cleanly against the latest sources (unless something's changed in the last 10 days). Before merging, maintainers would probably want to rename the property names (which have underscores in this patch) to better conform to the other driver properties which use camelcaps for the most part. I have also attached a "localAddress" patch that I find useful (I think I posted it myself a while ago, but in any case here's an updated patch that should apply more cleanly against recent sources). -Scott
Attachment
Is it possible to establish a better issue tracking system than this static http://jdbc.postgresql.org/todo.html or mailing list? So that community knows what is going on? What to expect in next release. Since the project is hosted on github now. Why not leverage it's build-in features? https://github.com/features/projects/issues __________________________ Shijun Kong On 8/21/12 7:08 PM, "Scott Harrington" <scotth01@sns-usa.com> wrote: >On Tue, 21 Aug 2012, Shijun Kong wrote: > >> I read a thread somewhere that somebody contributed a patch for adding >>support of configurable send/receive buffer size. Did it ever commit into >> master branch? I did not see any commit message about this change for >>last 12 months. > >I wondered the same last weekend and found that the patch had NOT yet >found its way into pgjdbc on github. In case it helps you, I've attached >that old patch in a form that should apply cleanly against the latest >sources (unless something's changed in the last 10 days). > >Before merging, maintainers would probably want to rename the property >names (which have underscores in this patch) to better conform to the >other driver properties which use camelcaps for the most part. > >I have also attached a "localAddress" patch that I find useful (I think I >posted it myself a while ago, but in any case here's an updated patch >that >should apply more cleanly against recent sources). > >-Scott This email message and any attachments may contain legally privileged or confidential information intended solely for theuse of the individual or entity to whom it is addressed. If the reader of this message is not the intended recipient,you are hereby notified that any reading, dissemination, distribution or copying of this message or its attachmentsis strictly prohibited. If you have received this message in error, please notify us immediately by telephone,fax or email and delete the message and all attachments to the message. Any views or opinions expressed are solelythose of the author and do not necessarily represent those of Investor Analytics LLC.
Shijun, Yes, I am leaning towards that. The mailing list does seem to be onerous. Dave Cramer dave.cramer(at)credativ(dot)ca http://www.credativ.ca On Fri, Aug 24, 2012 at 4:45 PM, Shijun Kong <skong@investoranalytics.com> wrote: > Is it possible to establish a better issue tracking system than this > static http://jdbc.postgresql.org/todo.html or mailing list? So that > community knows what is going on? What to expect in next release. > > Since the project is hosted on github now. Why not leverage it's build-in > features? https://github.com/features/projects/issues > __________________________ > > Shijun Kong > > > > > On 8/21/12 7:08 PM, "Scott Harrington" <scotth01@sns-usa.com> wrote: > >>On Tue, 21 Aug 2012, Shijun Kong wrote: >> >>> I read a thread somewhere that somebody contributed a patch for adding >>>support of configurable send/receive buffer size. Did it ever commit into >>> master branch? I did not see any commit message about this change for >>>last 12 months. >> >>I wondered the same last weekend and found that the patch had NOT yet >>found its way into pgjdbc on github. In case it helps you, I've attached >>that old patch in a form that should apply cleanly against the latest >>sources (unless something's changed in the last 10 days). >> >>Before merging, maintainers would probably want to rename the property >>names (which have underscores in this patch) to better conform to the >>other driver properties which use camelcaps for the most part. >> >>I have also attached a "localAddress" patch that I find useful (I think I >>posted it myself a while ago, but in any case here's an updated patch >>that >>should apply more cleanly against recent sources). >> >>-Scott > > > This email message and any attachments may contain legally privileged or confidential information intended solely forthe use of the individual or entity to whom it is addressed. If the reader of this message is not the intended recipient,you are hereby notified that any reading, dissemination, distribution or copying of this message or its attachmentsis strictly prohibited. If you have received this message in error, please notify us immediately by telephone,fax or email and delete the message and all attachments to the message. Any views or opinions expressed are solelythose of the author and do not necessarily represent those of Investor Analytics LLC. > > > -- > Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-jdbc
On 08/25/2012 04:45 AM, Shijun Kong wrote: > Is it possible to establish a better issue tracking system than this > static http://jdbc.postgresql.org/todo.html or mailing list? +1 The -BUGS list works ok for the main project because there are enough people with the time and expertise to promptly act on issues. Even then things slip through the cracks quite a bit. It seems it hasn't been working great for PgJDBC. > Since the project is hosted on github now. Why not leverage it's > build-in features? https://github.com/features/projects/issues Also very much +1 from me, if Dave's OK adding more people to the PgJDBC org membership list. GitHub provides facilities canned and ready to use, including a simple issue tracker, wiki, and patch tracking system. At least for the purpose of catching up on the backlog and finding missed patches it seems wise to use it. Since Pg proper doesn't use a tracker, and one appears to be necessary at least for catch-up, I'd suggest using that one. Re catch-up: The first thing to do will be find all messages with patch attachments. For that it'd be quite handy to have a dump of the last year or two's archives. I can manually download the mbox files, but ... since the list manager supports full text search, surely it's in a database too? How're the chances of getting a DB dump of the PgJDBC list for the last couple of years? I'll ask on pgsql-web . -- Craig Ringer
So one of the problems with github is that there is no way to send email to the list. Unless everyone that is on the list now "watches" pgjdbc on github they don't get notifications. Dave Cramer dave.cramer(at)credativ(dot)ca http://www.credativ.ca On Sat, Aug 25, 2012 at 11:26 AM, Craig Ringer <ringerc@ringerc.id.au> wrote: > On 08/25/2012 04:45 AM, Shijun Kong wrote: >> >> Is it possible to establish a better issue tracking system than this >> static http://jdbc.postgresql.org/todo.html or mailing list? > > > +1 > > The -BUGS list works ok for the main project because there are enough people > with the time and expertise to promptly act on issues. Even then things slip > through the cracks quite a bit. It seems it hasn't been working great for > PgJDBC. > > > >> Since the project is hosted on github now. Why not leverage it's >> build-in features? https://github.com/features/projects/issues > > Also very much +1 from me, if Dave's OK adding more people to the PgJDBC org > membership list. > > GitHub provides facilities canned and ready to use, including a simple issue > tracker, wiki, and patch tracking system. At least for the purpose of > catching up on the backlog and finding missed patches it seems wise to use > it. Since Pg proper doesn't use a tracker, and one appears to be necessary > at least for catch-up, I'd suggest using that one. > > > Re catch-up: > > The first thing to do will be find all messages with patch attachments. For > that it'd be quite handy to have a dump of the last year or two's archives. > I can manually download the mbox files, but ... since the list manager > supports full text search, surely it's in a database too? > > How're the chances of getting a DB dump of the PgJDBC list for the last > couple of years? I'll ask on pgsql-web . > > -- > Craig Ringer
On 25/08/2012 23:24, Dave Cramer wrote: > So one of the problems with github is that there is no way to send > email to the list. Unless everyone that is on the list now "watches" > pgjdbc on github they don't get notifications. > I haven't used Github yet, but could one of the jdbc project/mailing list admins add the list address as a user and have it receive notifications? I'd guess you'd have to add the github return address as a subscriber to the jdbc list and configure it to not have any messages sent to it. Also, the list may initially be polluted with account confirmation, etc emails Apologies if that is a mad suggestion. John
On 08/26/2012 06:24 AM, Dave Cramer wrote: > So one of the problems with github is that there is no way to send > email to the list. Unless everyone that is on the list now "watches" > pgjdbc on github they don't get notifications. Is that bad? I find mailing lists that get continuously spammed with automatic notifications from trackers to be a real pain, and personally strongly prefer to explicitly sign up for notifications that I want. If you want a list for notifications *please* make it a different one to psql-jdbc so this list remains useful for human-to-human conversation. -- Craig Ringer
On 27/08/12 00:09, Craig Ringer wrote: > On 08/26/2012 06:24 AM, Dave Cramer wrote: >> So one of the problems with github is that there is no way to send >> email to the list. Unless everyone that is on the list now "watches" >> pgjdbc on github they don't get notifications. > > Is that bad? > > I find mailing lists that get continuously spammed with automatic > notifications from trackers to be a real pain, and personally strongly > prefer to explicitly sign up for notifications that I want. > > If you want a list for notifications *please* make it a different one > to psql-jdbc so this list remains useful for human-to-human conversation. > > -- > Craig Ringer > > > +1
I've applied this patch with changes to use camelCase for sendBufferSize, and receiveBufferSize to 9.2 Originally supplied by Bernd Helme Dave Cramer dave.cramer(at)credativ(dot)ca http://www.credativ.ca On Tue, Aug 21, 2012 at 7:08 PM, Scott Harrington <scotth01@sns-usa.com> wrote: > On Tue, 21 Aug 2012, Shijun Kong wrote: > >> I read a thread somewhere that somebody contributed a patch for adding >> support of configurable send/receive buffer size. Did it ever commit into >> master branch? I did not see any commit message about this change for last >> 12 months. > > > I wondered the same last weekend and found that the patch had NOT yet found > its way into pgjdbc on github. In case it helps you, I've attached that old > patch in a form that should apply cleanly against the latest sources (unless > something's changed in the last 10 days). > > Before merging, maintainers would probably want to rename the property names > (which have underscores in this patch) to better conform to the other driver > properties which use camelcaps for the most part. > > I have also attached a "localAddress" patch that I find useful (I think I > posted it myself a while ago, but in any case here's an updated patch that > should apply more cleanly against recent sources). > > -Scott > > -- > Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-jdbc >
Scott, As you can see the code patch is one thing. I also have to add documentation, and test cases. It would be much easier if those things were also included in the patch. Dave Cramer dave.cramer(at)credativ(dot)ca http://www.credativ.ca On Wed, Sep 12, 2012 at 6:47 AM, Scott Harrington <scotth@sns-usa.com> wrote: > Thank you Dave, will you consider the localAddress patch also? > > > On Tue, 11 Sep 2012, Dave Cramer wrote: > >> I've applied this patch with changes to use camelCase for >> sendBufferSize, and receiveBufferSize to 9.2 >> Originally supplied by Bernd Helme >> >> Dave Cramer >> >> dave.cramer(at)credativ(dot)ca >> http://www.credativ.ca >> >> >> On Tue, Aug 21, 2012 at 7:08 PM, Scott Harrington <scotth01@sns-usa.com> >> wrote: >>> >>> On Tue, 21 Aug 2012, Shijun Kong wrote: >>> >>>> I read a thread somewhere that somebody contributed a patch for adding >>>> support of configurable send/receive buffer size. Did it ever commit >>>> into >>>> master branch? I did not see any commit message about this change for >>>> last >>>> 12 months. >>> >>> >>> >>> I wondered the same last weekend and found that the patch had NOT yet >>> found >>> its way into pgjdbc on github. In case it helps you, I've attached that >>> old >>> patch in a form that should apply cleanly against the latest sources >>> (unless >>> something's changed in the last 10 days). >>> >>> Before merging, maintainers would probably want to rename the property >>> names >>> (which have underscores in this patch) to better conform to the other >>> driver >>> properties which use camelcaps for the most part. >>> >>> I have also attached a "localAddress" patch that I find useful (I think I >>> posted it myself a while ago, but in any case here's an updated patch >>> that >>> should apply more cleanly against recent sources). >>> >>> -Scott >>> >>> -- >>> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgsql-jdbc >>> >> >> >> -- >> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgsql-jdbc >> >
Hi Dave, I understand completely - I will "enrich" the LocalAddress patch at least with documentation, but as for a test case, I am not sure we can pick an appropriate value for the localAddress (possibly "127.0.0.1" ?) that would work reliably in different environments. Suggestions? On Wed, 12 Sep 2012, Dave Cramer wrote: > Scott, > > As you can see the code patch is one thing. I also have to add > documentation, and test cases. It would be much easier if those > things were also included in the patch. > > > Dave Cramer > > dave.cramer(at)credativ(dot)ca > http://www.credativ.ca > > > On Wed, Sep 12, 2012 at 6:47 AM, Scott Harrington <scotth@sns-usa.com> wrote: >> Thank you Dave, will you consider the localAddress patch also? >> >> >> On Tue, 11 Sep 2012, Dave Cramer wrote: >> >>> I've applied this patch with changes to use camelCase for >>> sendBufferSize, and receiveBufferSize to 9.2 >>> Originally supplied by Bernd Helme >>> >>> Dave Cramer >>> >>> dave.cramer(at)credativ(dot)ca >>> http://www.credativ.ca >>> >>> >>> On Tue, Aug 21, 2012 at 7:08 PM, Scott Harrington <scotth01@sns-usa.com> >>> wrote: >>>> >>>> On Tue, 21 Aug 2012, Shijun Kong wrote: >>>> >>>>> I read a thread somewhere that somebody contributed a patch for adding >>>>> support of configurable send/receive buffer size. Did it ever commit >>>>> into >>>>> master branch? I did not see any commit message about this change for >>>>> last >>>>> 12 months. >>>> >>>> >>>> >>>> I wondered the same last weekend and found that the patch had NOT yet >>>> found >>>> its way into pgjdbc on github. In case it helps you, I've attached that >>>> old >>>> patch in a form that should apply cleanly against the latest sources >>>> (unless >>>> something's changed in the last 10 days). >>>> >>>> Before merging, maintainers would probably want to rename the property >>>> names >>>> (which have underscores in this patch) to better conform to the other >>>> driver >>>> properties which use camelcaps for the most part. >>>> >>>> I have also attached a "localAddress" patch that I find useful (I think I >>>> posted it myself a while ago, but in any case here's an updated patch >>>> that >>>> should apply more cleanly against recent sources). >>>> >>>> -Scott >>>> >>>> -- >>>> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgsql-jdbc >>>> >>> >>> >>> -- >>> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgsql-jdbc >>> >> >
Scott, There is a build.local.properties, or build.xml where you can set values. Agreed it may be difficult to test. Dave Cramer dave.cramer(at)credativ(dot)ca http://www.credativ.ca On Wed, Sep 12, 2012 at 7:24 AM, Scott Harrington <scotth01@sns-usa.com> wrote: > Hi Dave, I understand completely - I will "enrich" the LocalAddress patch at > least with documentation, but as for a test case, I am not sure we can pick > an appropriate value for the localAddress (possibly "127.0.0.1" ?) that > would work reliably in different environments. Suggestions? > > > > On Wed, 12 Sep 2012, Dave Cramer wrote: > >> Scott, >> >> As you can see the code patch is one thing. I also have to add >> documentation, and test cases. It would be much easier if those >> things were also included in the patch. >> >> >> Dave Cramer >> >> dave.cramer(at)credativ(dot)ca >> http://www.credativ.ca >> >> >> On Wed, Sep 12, 2012 at 6:47 AM, Scott Harrington <scotth@sns-usa.com> >> wrote: >>> >>> Thank you Dave, will you consider the localAddress patch also? >>> >>> >>> On Tue, 11 Sep 2012, Dave Cramer wrote: >>> >>>> I've applied this patch with changes to use camelCase for >>>> sendBufferSize, and receiveBufferSize to 9.2 >>>> Originally supplied by Bernd Helme >>>> >>>> Dave Cramer >>>> >>>> dave.cramer(at)credativ(dot)ca >>>> http://www.credativ.ca >>>> >>>> >>>> On Tue, Aug 21, 2012 at 7:08 PM, Scott Harrington <scotth01@sns-usa.com> >>>> wrote: >>>>> >>>>> >>>>> On Tue, 21 Aug 2012, Shijun Kong wrote: >>>>> >>>>>> I read a thread somewhere that somebody contributed a patch for adding >>>>>> support of configurable send/receive buffer size. Did it ever commit >>>>>> into >>>>>> master branch? I did not see any commit message about this change for >>>>>> last >>>>>> 12 months. >>>>> >>>>> >>>>> >>>>> >>>>> I wondered the same last weekend and found that the patch had NOT yet >>>>> found >>>>> its way into pgjdbc on github. In case it helps you, I've attached that >>>>> old >>>>> patch in a form that should apply cleanly against the latest sources >>>>> (unless >>>>> something's changed in the last 10 days). >>>>> >>>>> Before merging, maintainers would probably want to rename the property >>>>> names >>>>> (which have underscores in this patch) to better conform to the other >>>>> driver >>>>> properties which use camelcaps for the most part. >>>>> >>>>> I have also attached a "localAddress" patch that I find useful (I think >>>>> I >>>>> posted it myself a while ago, but in any case here's an updated patch >>>>> that >>>>> should apply more cleanly against recent sources). >>>>> >>>>> -Scott >>>>> >>>>> -- >>>>> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgsql-jdbc >>>>> >>>> >>>> >>>> -- >>>> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgsql-jdbc >>>> >>> >> >
Thank you Dave, will you consider the localAddress patch also? On Tue, 11 Sep 2012, Dave Cramer wrote: > I've applied this patch with changes to use camelCase for > sendBufferSize, and receiveBufferSize to 9.2 > Originally supplied by Bernd Helme > > Dave Cramer > > dave.cramer(at)credativ(dot)ca > http://www.credativ.ca > > > On Tue, Aug 21, 2012 at 7:08 PM, Scott Harrington <scotth01@sns-usa.com> wrote: >> On Tue, 21 Aug 2012, Shijun Kong wrote: >> >>> I read a thread somewhere that somebody contributed a patch for adding >>> support of configurable send/receive buffer size. Did it ever commit into >>> master branch? I did not see any commit message about this change for last >>> 12 months. >> >> >> I wondered the same last weekend and found that the patch had NOT yet found >> its way into pgjdbc on github. In case it helps you, I've attached that old >> patch in a form that should apply cleanly against the latest sources (unless >> something's changed in the last 10 days). >> >> Before merging, maintainers would probably want to rename the property names >> (which have underscores in this patch) to better conform to the other driver >> properties which use camelcaps for the most part. >> >> I have also attached a "localAddress" patch that I find useful (I think I >> posted it myself a while ago, but in any case here's an updated patch that >> should apply more cleanly against recent sources). >> >> -Scott >> >> -- >> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgsql-jdbc >> > > > -- > Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-jdbc >