Thread: Binary I/O for isn extension
Hi.
Attached is a small patch which adds binary input/output for the types added by the isn extension.
Shay
Attachment
Hi, Thanks for the patch, you can add it to our commitfest app so it gets reviewed in the next commitfest. https://commitfest.postgresql.org/ A suggestion to make it easier for your patch to be accepted: When adding new functions to an extension you need to bump the version of the extension by renaming the file, updating the .control file, creating an upgrade script, and updating the Makefile to include the new files. Andreas
Hello, > Attached is a small patch which adds binary input/output for the types > added by the isn extension. I added this patch to the next CF (2016-09) under "Miscellaneous". Out of curiosity, what is the motivation? -- Fabien.
When adding new functions to an extension you need to bump the version of the extension by renaming the file, updating the .control file, creating an upgrade script, and updating the Makefile to include the new files.
Thanks for the guidance, I'll fix all that and resubmit a patch.
> Thanks for the patch, you can add it to our commitfest app so it gets > reviewed in the next commitfest. I did this. > A suggestion to make it easier for your patch to be accepted: > > When adding new functions to an extension you need to bump the version of the > extension by renaming the file, updating the .control file, creating an > upgrade script, and updating the Makefile to include the new files. Indeed. Moreover I'm not sure that a type may me updated incrementaly to add new send/receive functions. -- Fabien.
I added this patch to the next CF (2016-09) under "Miscellaneous".
Thanks!
Out of curiosity, what is the motivation?
I'm the owner of Npgsql, the open-source .NET driver for PostgreSQL, which is a binary-first driver. That is, working with types that have no binary I/O is possible but awkward.
I hope the general direction is (or will be) to have binary I/O for all supported types, both for compatibility with binary-first consumers such as Npgsql and for general efficiency.
When adding new functions to an extension you need to bump the version of the extension by renaming the file, updating the .control file, creating an upgrade script, and updating the Makefile to include the new files.
Attached is a new version of the patch, adding an upgrade script and the rest of it. Note that because, as Fabien noted, there's doesn't seem to be a way to add send/receive functions with ALTER TYPE, I did that by updating pg_type directly - hope that's OK.
Attachment
Hello Shay, > Attached is a new version of the patch, adding an upgrade script and the > rest of it. Note that because, as Fabien noted, there's doesn't seem to be > a way to add send/receive functions with ALTER TYPE, I did that by updating > pg_type directly - hope that's OK. This patch does not apply anymore, because there as been an update in between to mark relevant contrib functions as "parallel". Could you update the patch? -- Fabien.
On Mon, Aug 22, 2016 at 8:14 AM, Fabien COELHO <coelho@cri.ensmp.fr> wrote: > Hello Shay, >> Attached is a new version of the patch, adding an upgrade script and the >> rest of it. Note that because, as Fabien noted, there's doesn't seem to be >> a way to add send/receive functions with ALTER TYPE, I did that by >> updating >> pg_type directly - hope that's OK. > > This patch does not apply anymore, because there as been an update in > between to mark relevant contrib functions as "parallel". > > Could you update the patch? So, it's been over a month since this request, and there doesn't seem to be an update to this patch. The CommitFest is over in 2 days, so I've marked this "Returned with Feedback". Shay, please feel free to resubmit for the next CommitFest. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
<div dir="ltr">Sorry about this, I just haven't had a free moment (and it's definitely not very high priority...)</div><divclass="gmail_extra"><br /><div class="gmail_quote">On Wed, Sep 28, 2016 at 5:04 PM, Robert Haas <spandir="ltr"><<a href="mailto:robertmhaas@gmail.com" target="_blank">robertmhaas@gmail.com</a>></span> wrote:<br/><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">OnMon, Aug 22, 2016 at 8:14 AM, Fabien COELHO <<a href="mailto:coelho@cri.ensmp.fr">coelho@cri.ensmp.fr</a>>wrote:<br /> > Hello Shay,<br /> >> Attached is a newversion of the patch, adding an upgrade script and the<br /> >> rest of it. Note that because, as Fabien noted,there's doesn't seem to be<br /> >> a way to add send/receive functions with ALTER TYPE, I did that by<br />>> updating<br /> >> pg_type directly - hope that's OK.<br /> ><br /> > This patch does not apply anymore,because there as been an update in<br /> > between to mark relevant contrib functions as "parallel".<br /> ><br/> > Could you update the patch?<br /><br /></span>So, it's been over a month since this request, and there doesn'tseem<br /> to be an update to this patch. The CommitFest is over in 2 days, so<br /> I've marked this "Returned withFeedback". Shay, please feel free to<br /> resubmit for the next CommitFest.<br /><span class="HOEnZb"><font color="#888888"><br/> --<br /> Robert Haas<br /> EnterpriseDB: <a href="http://www.enterprisedb.com" rel="noreferrer" target="_blank">http://www.enterprisedb.com</a><br/> The Enterprise PostgreSQL Company<br /></font></span></blockquote></div><br/></div>
On Wed, Sep 28, 2016 at 2:05 PM, Shay Rojansky <roji@roji.org> wrote: > Sorry about this, I just haven't had a free moment (and it's definitely not > very high priority...) No issues, just cleaning house. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company