Thread: pgbench - remove unused clientDone parameter

Remove pgbench clientDone unused "ok" parameter.

I cannot get the point of keeping a useless parameter, which is probably 
there because at some point in the past it was used. If it is needed some 
day it can always be reinserted.

-- 
Fabien.

Fabien wrote:
> 
> Remove pgbench clientDone unused "ok" parameter.

Seems useless, yeah, removed.

> I cannot get the point of keeping a useless parameter, which is probably
> there because at some point in the past it was used. If it is needed some
> day it can always be reinserted.

Actually it was introduced as an unused argument in 3da0dfb4b146.  I
don't quite see the reason, I guess they thought it'd become used at
some point.  Since it hasn't in the 7 intervening years, it seems safe
to remove it.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

>> Remove pgbench clientDone unused "ok" parameter.
>
> Seems useless, yeah, removed.

Good!

> Actually it was introduced as an unused argument in 3da0dfb4b146.

Strange indeed. I did not thought to dig into the history.


I switchted the corresponding commitfest entry as committed.

Thanks,

-- 
Fabien.