Re: pgbench - remove unused clientDone parameter - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pgbench - remove unused clientDone parameter
Date
Msg-id 20160401201318.GA83554@alvherre.pgsql
Whole thread Raw
In response to pgbench - remove unused clientDone parameter  (Fabien <coelho@cri.ensmp.fr>)
Responses Re: pgbench - remove unused clientDone parameter  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Fabien wrote:
> 
> Remove pgbench clientDone unused "ok" parameter.

Seems useless, yeah, removed.

> I cannot get the point of keeping a useless parameter, which is probably
> there because at some point in the past it was used. If it is needed some
> day it can always be reinserted.

Actually it was introduced as an unused argument in 3da0dfb4b146.  I
don't quite see the reason, I guess they thought it'd become used at
some point.  Since it hasn't in the 7 intervening years, it seems safe
to remove it.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches
Next
From: Alvaro Herrera
Date:
Subject: Re: Fix handling of invalid sockets returned by PQsocket()