Thread: tab completion for CREATE USER MAPPING

tab completion for CREATE USER MAPPING

From
Fujii Masao
Date:
Hi,

Attached patch implements the tab-completion for CREATE USER MAPPING command.
Comments?

Regards,

--
Fujii Masao

Attachment

Re: tab completion for CREATE USER MAPPING

From
Tom Lane
Date:
Fujii Masao <masao.fujii@gmail.com> writes:
> Attached patch implements the tab-completion for CREATE USER MAPPING command.
> Comments?

I think it's really bad style to use "Query_for_list_of_users"
as the name of a query that does not in fact deliver a list of
user names, but something else with only one specialized use.
Something like "Query_for_list_of_users_plus_MAPPING" would be
less likely to trip up the unwary in future patches.
        regards, tom lane