Re: tab completion for CREATE USER MAPPING - Mailing list pgsql-hackers

From Tom Lane
Subject Re: tab completion for CREATE USER MAPPING
Date
Msg-id 31675.1456239223@sss.pgh.pa.us
Whole thread Raw
In response to tab completion for CREATE USER MAPPING  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Fujii Masao <masao.fujii@gmail.com> writes:
> Attached patch implements the tab-completion for CREATE USER MAPPING command.
> Comments?

I think it's really bad style to use "Query_for_list_of_users"
as the name of a query that does not in fact deliver a list of
user names, but something else with only one specialized use.
Something like "Query_for_list_of_users_plus_MAPPING" would be
less likely to trip up the unwary in future patches.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [JDBC] JDBC behaviour
Next
From: Alvaro Herrera
Date:
Subject: Re: Sanity checking for ./configure options?