Thread: Close handle leak in SSPI auth

Close handle leak in SSPI auth

From
Christian Ullrich
Date:
Hello,

here's a one-line patch to close a handle leak in pg_SSPI_recvauth().

According to the docs, the token retrieved with 
QuerySecurityContextToken() must be closed.

-- 
Christian


Re: Close handle leak in SSPI auth

From
Magnus Hagander
Date:
On Sun, Jan 10, 2016 at 8:58 PM, Christian Ullrich <chris@chrullrich.net> wrote:
Hello,

here's a one-line patch to close a handle leak in pg_SSPI_recvauth().

According to the docs, the token retrieved with QuerySecurityContextToken() must be closed.

We still leak it in a number of the error paths in this case, but I don't think we need to care about those -- since they are hard errors, the process exits shortly thereafter anyway. 

Applied and backpatched, thanks.

--