Re: Close handle leak in SSPI auth - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Close handle leak in SSPI auth
Date
Msg-id CABUevEysPW43m7QnA7JjTZk9KEZy0=nD4E_eORTX40xEHs+rsg@mail.gmail.com
Whole thread Raw
In response to Close handle leak in SSPI auth  (Christian Ullrich <chris@chrullrich.net>)
List pgsql-hackers
On Sun, Jan 10, 2016 at 8:58 PM, Christian Ullrich <chris@chrullrich.net> wrote:
Hello,

here's a one-line patch to close a handle leak in pg_SSPI_recvauth().

According to the docs, the token retrieved with QuerySecurityContextToken() must be closed.

We still leak it in a number of the error paths in this case, but I don't think we need to care about those -- since they are hard errors, the process exits shortly thereafter anyway. 

Applied and backpatched, thanks.

--

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: Removing Functionally Dependent GROUP BY Columns
Next
From: Rushabh Lathia
Date:
Subject: Re: Optimization for updating foreign tables in Postgres FDW