Postgres Pro
Downloads
Home   >   mailing lists

Thread: Small fix in pg_rewind (redundant declaration)

Small fix in pg_rewind (redundant declaration)

From
YUriy Zhuravlev
Date:
Hello hackers.
I've stumbled upon a strange code.
In src/bin/pg_rewind/datapagemap.h  we decalre:
extern void datapagemap_destroy(datapagemap_t *map);
But nowhere is implemented. I think the declaration of this function must be 
removed.
I'm not sure that this trivial things needed patch.

Thanks. 

-- 
YUriy Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Re: Small fix in pg_rewind (redundant declaration)

From
Michael Paquier
Date:
On Thu, Dec 17, 2015 at 9:23 PM, YUriy Zhuravlev
<u.zhuravlev@postgrespro.ru> wrote:
> Hello hackers.
> I've stumbled upon a strange code.
> In src/bin/pg_rewind/datapagemap.h  we decalre:
> extern void datapagemap_destroy(datapagemap_t *map);
> But nowhere is implemented. I think the declaration of this function must be
> removed.
> I'm not sure that this trivial things needed patch.

Nicely noticed. That's a bug present as well in the 9.3 and 9.4
versions of pg_rewind (just fixed it there). datapagemap_create can be
additionally removed.
-- 
Michael

Re: Small fix in pg_rewind (redundant declaration)

From
Tom Lane
Date:
Michael Paquier <michael.paquier@gmail.com> writes:
> On Thu, Dec 17, 2015 at 9:23 PM, YUriy Zhuravlev
> <u.zhuravlev@postgrespro.ru> wrote:
>> Hello hackers.
>> I've stumbled upon a strange code.
>> In src/bin/pg_rewind/datapagemap.h  we decalre:
>> extern void datapagemap_destroy(datapagemap_t *map);
>> But nowhere is implemented. I think the declaration of this function must be
>> removed.
>> I'm not sure that this trivial things needed patch.

> Nicely noticed. That's a bug present as well in the 9.3 and 9.4
> versions of pg_rewind (just fixed it there). datapagemap_create can be
> additionally removed.

Done.
        regards, tom lane

Re: Small fix in pg_rewind (redundant declaration)

From
Michael Paquier
Date:
On Fri, Dec 18, 2015 at 10:22 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Done.

Thanks.
-- 
Michael