Re: Small fix in pg_rewind (redundant declaration) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Small fix in pg_rewind (redundant declaration)
Date
Msg-id CAB7nPqTmz-ybU1pVUvGTxtgcR-we_FYryfq4dMpUk3+ktd4CJg@mail.gmail.com
Whole thread Raw
In response to Small fix in pg_rewind (redundant declaration)  (YUriy Zhuravlev <u.zhuravlev@postgrespro.ru>)
Responses Re: Small fix in pg_rewind (redundant declaration)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Dec 17, 2015 at 9:23 PM, YUriy Zhuravlev
<u.zhuravlev@postgrespro.ru> wrote:
> Hello hackers.
> I've stumbled upon a strange code.
> In src/bin/pg_rewind/datapagemap.h  we decalre:
> extern void datapagemap_destroy(datapagemap_t *map);
> But nowhere is implemented. I think the declaration of this function must be
> removed.
> I'm not sure that this trivial things needed patch.

Nicely noticed. That's a bug present as well in the 9.3 and 9.4
versions of pg_rewind (just fixed it there). datapagemap_create can be
additionally removed.
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: extend pgbench expressions with functions
Next
From: Tom Lane
Date:
Subject: Re: Small fix in pg_rewind (redundant declaration)