Thread: pg_resetxlog sentences

pg_resetxlog sentences

From
Euler Taveira
Date:
Hi,

While updating translations, I came across those almost similar sentences.

pg_controldata.c

273     printf(_("Latest checkpoint's oldestCommitTs:   %u\n"),
274            ControlFile.checkPointCopy.oldestCommitTs);

pg_resetxlog.c

  668     printf(_("Latest checkpoint's oldest CommitTs:  %u\n"),
  669            ControlFile.checkPointCopy.oldestCommitTs);
  670     printf(_("Latest checkpoint's newest CommitTs:  %u\n"),
  671            ControlFile.checkPointCopy.newestCommitTs);

To be consistent, let's change pg_resetxlog to mimic pg_controldata
sentence. Patch is attached. It is new in 9.5 so backpatch is needed.


--
    Euler Taveira                   Timbira - http://www.timbira.com.br/
    PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachment

Re: pg_resetxlog sentences

From
Robert Haas
Date:
On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler@timbira.com.br> wrote:
> While updating translations, I came across those almost similar sentences.
>
> pg_controldata.c
>
> 273     printf(_("Latest checkpoint's oldestCommitTs:   %u\n"),
> 274            ControlFile.checkPointCopy.oldestCommitTs);
>
> pg_resetxlog.c
>
>  668     printf(_("Latest checkpoint's oldest CommitTs:  %u\n"),
>  669            ControlFile.checkPointCopy.oldestCommitTs);
>  670     printf(_("Latest checkpoint's newest CommitTs:  %u\n"),
>  671            ControlFile.checkPointCopy.newestCommitTs);
>
> To be consistent, let's change pg_resetxlog to mimic pg_controldata
> sentence. Patch is attached. It is new in 9.5 so backpatch is needed.

Seems like a good idea to me.  Anyone disagree?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Re: pg_resetxlog sentences

From
Alvaro Herrera
Date:
Robert Haas wrote:
> On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler@timbira.com.br> wrote:
> > While updating translations, I came across those almost similar sentences.
> >
> > pg_controldata.c
> >
> > 273     printf(_("Latest checkpoint's oldestCommitTs:   %u\n"),
> > 274            ControlFile.checkPointCopy.oldestCommitTs);
> >
> > pg_resetxlog.c
> >
> >  668     printf(_("Latest checkpoint's oldest CommitTs:  %u\n"),
> >  669            ControlFile.checkPointCopy.oldestCommitTs);
> >  670     printf(_("Latest checkpoint's newest CommitTs:  %u\n"),
> >  671            ControlFile.checkPointCopy.newestCommitTs);
> >
> > To be consistent, let's change pg_resetxlog to mimic pg_controldata
> > sentence. Patch is attached. It is new in 9.5 so backpatch is needed.
> 
> Seems like a good idea to me.  Anyone disagree?

OK with me.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Re: pg_resetxlog sentences

From
Fujii Masao
Date:
On Thu, Sep 17, 2015 at 5:00 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Robert Haas wrote:
>> On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler@timbira.com.br> wrote:
>> > While updating translations, I came across those almost similar sentences.
>> >
>> > pg_controldata.c
>> >
>> > 273     printf(_("Latest checkpoint's oldestCommitTs:   %u\n"),
>> > 274            ControlFile.checkPointCopy.oldestCommitTs);
>> >
>> > pg_resetxlog.c
>> >
>> >  668     printf(_("Latest checkpoint's oldest CommitTs:  %u\n"),
>> >  669            ControlFile.checkPointCopy.oldestCommitTs);
>> >  670     printf(_("Latest checkpoint's newest CommitTs:  %u\n"),
>> >  671            ControlFile.checkPointCopy.newestCommitTs);
>> >
>> > To be consistent, let's change pg_resetxlog to mimic pg_controldata
>> > sentence. Patch is attached. It is new in 9.5 so backpatch is needed.
>>
>> Seems like a good idea to me.  Anyone disagree?
>
> OK with me.

+1

One relevant question is; why doesn't pg_controldata report newestCommitTs?

Regards,

-- 
Fujii Masao



Re: pg_resetxlog sentences

From
Alvaro Herrera
Date:
Fujii Masao wrote:
> On Thu, Sep 17, 2015 at 5:00 AM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:
> > Robert Haas wrote:
> >> On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler@timbira.com.br> wrote:
> >> > While updating translations, I came across those almost similar sentences.
> >> >
> >> > pg_controldata.c
> >> >
> >> > 273     printf(_("Latest checkpoint's oldestCommitTs:   %u\n"),
> >> > 274            ControlFile.checkPointCopy.oldestCommitTs);
> >> >
> >> > pg_resetxlog.c
> >> >
> >> >  668     printf(_("Latest checkpoint's oldest CommitTs:  %u\n"),
> >> >  669            ControlFile.checkPointCopy.oldestCommitTs);
> >> >  670     printf(_("Latest checkpoint's newest CommitTs:  %u\n"),
> >> >  671            ControlFile.checkPointCopy.newestCommitTs);
> >> >
> >> > To be consistent, let's change pg_resetxlog to mimic pg_controldata
> >> > sentence. Patch is attached. It is new in 9.5 so backpatch is needed.
> >>
> >> Seems like a good idea to me.  Anyone disagree?
> >
> > OK with me.
> 
> +1
> 
> One relevant question is; why doesn't pg_controldata report newestCommitTs?

Most likely an oversight.  As I recall, we added newestCommitTs in a
later version of the patch; we probably patched pg_controldata earlier
and then failed to realize that we needed to add the new field.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Re: pg_resetxlog sentences

From
Euler Taveira
Date:
On 17-09-2015 00:25, Fujii Masao wrote:
> One relevant question is; why doesn't pg_controldata report newestCommitTs?
>
I thought about it while looking at the code but forgot to ask. AFAICS
it is an oversight. See attached patch.


--
    Euler Taveira                   Timbira - http://www.timbira.com.br/
    PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachment

Re: pg_resetxlog sentences

From
Fujii Masao
Date:
On Fri, Sep 18, 2015 at 1:58 AM, Euler Taveira <euler@timbira.com.br> wrote:
> On 17-09-2015 00:25, Fujii Masao wrote:
>>
>> One relevant question is; why doesn't pg_controldata report
>> newestCommitTs?
>>
> I thought about it while looking at the code but forgot to ask. AFAICS it is
> an oversight. See attached patch.

Applied. Thanks!

Regards,

-- 
Fujii Masao