Re: pg_resetxlog sentences - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pg_resetxlog sentences
Date
Msg-id 20150916200019.GQ88970@alvherre.pgsql
Whole thread Raw
In response to Re: pg_resetxlog sentences  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pg_resetxlog sentences  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Robert Haas wrote:
> On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler@timbira.com.br> wrote:
> > While updating translations, I came across those almost similar sentences.
> >
> > pg_controldata.c
> >
> > 273     printf(_("Latest checkpoint's oldestCommitTs:   %u\n"),
> > 274            ControlFile.checkPointCopy.oldestCommitTs);
> >
> > pg_resetxlog.c
> >
> >  668     printf(_("Latest checkpoint's oldest CommitTs:  %u\n"),
> >  669            ControlFile.checkPointCopy.oldestCommitTs);
> >  670     printf(_("Latest checkpoint's newest CommitTs:  %u\n"),
> >  671            ControlFile.checkPointCopy.newestCommitTs);
> >
> > To be consistent, let's change pg_resetxlog to mimic pg_controldata
> > sentence. Patch is attached. It is new in 9.5 so backpatch is needed.
> 
> Seems like a good idea to me.  Anyone disagree?

OK with me.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Reliance on undefined behaviour in << operator
Next
From: Robert Haas
Date:
Subject: Re: Reliance on undefined behaviour in << operator