Thread: SSL TAP tests and chmod
Hi all, The TAP tests in src/test/ssl are using system() in combination with chmod, but perl has a command chmod integrated into it, and it would work better on Windows as well. The attached patch is aimed at fixing that. Regards, -- Michael
Attachment
On Fri, Jun 19, 2015 at 2:49 PM, Michael Paquier wrote: > The TAP tests in src/test/ssl are using system() in combination with > chmod, but perl has a command chmod integrated into it, and it would > work better on Windows as well. > The attached patch is aimed at fixing that. For the sake of the archives, this has been committed by Robert (thanks!): commit: ca3f43aa48a83013ea50aeee7cd193a5859c4587 author: Robert Haas <rhaas@postgresql.org> date: Fri, 19 Jun 2015 10:46:30 -0400 Change TAP test framework to not rely on having a chmod executable. This might not work at all on Windows, and is not ever efficient. Regards, -- Michael
On Sun, Jun 21, 2015 at 9:50 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Fri, Jun 19, 2015 at 2:49 PM, Michael Paquier wrote: >> The TAP tests in src/test/ssl are using system() in combination with >> chmod, but perl has a command chmod integrated into it, and it would >> work better on Windows as well. >> The attached patch is aimed at fixing that. > > For the sake of the archives, this has been committed by Robert (thanks!): > commit: ca3f43aa48a83013ea50aeee7cd193a5859c4587 > author: Robert Haas <rhaas@postgresql.org> > date: Fri, 19 Jun 2015 10:46:30 -0400 > Change TAP test framework to not rely on having a chmod executable. > > This might not work at all on Windows, and is not ever efficient. Whoops, sorry, I thought I had replied to this thread, but I guess I forgot. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company