Re: SSL TAP tests and chmod - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: SSL TAP tests and chmod
Date
Msg-id CAB7nPqRvU6yN3OUc2XU9niXx8O=fo6GsjyLj1DGo-WC76QZvrQ@mail.gmail.com
Whole thread Raw
In response to SSL TAP tests and chmod  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: SSL TAP tests and chmod  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Fri, Jun 19, 2015 at 2:49 PM, Michael Paquier wrote:
> The TAP tests in src/test/ssl are using system() in combination with
> chmod, but perl has a command chmod integrated into it, and it would
> work better on Windows as well.
> The attached patch is aimed at fixing that.

For the sake of the archives, this has been committed by Robert (thanks!):
commit: ca3f43aa48a83013ea50aeee7cd193a5859c4587
author: Robert Haas <rhaas@postgresql.org>
date: Fri, 19 Jun 2015 10:46:30 -0400
Change TAP test framework to not rely on having a chmod executable.

This might not work at all on Windows, and is not ever efficient.

Regards,
-- 
Michael



pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: pgbench - allow backslash-continuations in custom scripts
Next
From: Michael Paquier
Date:
Subject: Re: Backpatch src/test/modules to 9.3?