Thread: replication commands and index terms

replication commands and index terms

From
Fujii Masao
Date:
Hi,

I found that only CREATE_REPLICATION_SLOT of replication commands
is exposed as an index term in the document. Is this intentional?
If not, for the consistency, I think that we should either expose other
replication commands also as index terms, or remove
CREATE_REPLICATION_SLOT from the index. Thought?

Since I sometimes try to search the replication command in the index,
I'd feel inclined to expose all those commands as index terms...

Regards,

-- 
Fujii Masao



Re: replication commands and index terms

From
Robert Haas
Date:
On Thu, Aug 14, 2014 at 12:59 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> Since I sometimes try to search the replication command in the index,
> I'd feel inclined to expose all those commands as index terms...

+1.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Re: replication commands and index terms

From
Fujii Masao
Date:
On Fri, Aug 15, 2014 at 4:59 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, Aug 14, 2014 at 12:59 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> Since I sometimes try to search the replication command in the index,
>> I'd feel inclined to expose all those commands as index terms...
>
> +1.

Attached patch exposes replication commands as index terms.
Barring any objection, I will commit this.

Regards,

--
Fujii Masao

Attachment

Re: replication commands and index terms

From
Fujii Masao
Date:
On Fri, Aug 15, 2014 at 11:25 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Fri, Aug 15, 2014 at 4:59 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Thu, Aug 14, 2014 at 12:59 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>> Since I sometimes try to search the replication command in the index,
>>> I'd feel inclined to expose all those commands as index terms...
>>
>> +1.
>
> Attached patch exposes replication commands as index terms.
> Barring any objection, I will commit this.

Done.

Regards,

-- 
Fujii Masao