Postgres Pro
Downloads
Home   >   mailing lists

Thread: review: tab completion for set search_path TO

review: tab completion for set search_path TO

From
Pavel Stehule
Date:
Hello,

this patch https://commitfest.postgresql.org/action/patch_view?id=1443 is trivial with zero risk.

Patch is applicable without any issues, compilation was without any issues too.

Only one open question is there - should by system schemas visible for autocompleation  or not.

There was not 100% agreement in related discussion. I am inclined to think so preferable variant is without system schemas - they are used implicitly and has no sense use it on first position. But on second hand this detail is not significant and it is hard to get some objective arguments for one or second variant. Next, this behave can be simply changed without any impacts if we don't choose well now - so I would to mark this patch as ready for commit.

Regards

Pavel

Re: review: tab completion for set search_path TO

From
Michael Paquier
Date:
On Sun, Jun 22, 2014 at 2:22 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
Hello,

this patch https://commitfest.postgresql.org/action/patch_view?id=1443 is trivial with zero risk.

Patch is applicable without any issues, compilation was without any issues too.
Just wondering: why creating a new thread for a review and not reply directly reply to the exiting one? This makes the review/patch submission flow rather complicated to follow.
--
Michael

Re: review: tab completion for set search_path TO

From
Pavel Stehule
Date:

Hello

I am sorry, I expected so review shold to start with new thread. I was wrong, so next reviews I will use e existing threads

Regards

pavel

Dne 23. 6. 2014 7:39 "Michael Paquier" <michael.paquier@gmail.com> napsal(a):
On Sun, Jun 22, 2014 at 2:22 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
Hello,

this patch https://commitfest.postgresql.org/action/patch_view?id=1443 is trivial with zero risk.

Patch is applicable without any issues, compilation was without any issues too.
Just wondering: why creating a new thread for a review and not reply directly reply to the exiting one? This makes the review/patch submission flow rather complicated to follow.
--
Michael