review: tab completion for set search_path TO - Mailing list pgsql-hackers

From Pavel Stehule
Subject review: tab completion for set search_path TO
Date
Msg-id CAFj8pRD9g7BkyiDHT5j_-2uSJ_Gro3Y2qj110R0SNL9-fB4QOA@mail.gmail.com
Whole thread Raw
Responses Re: review: tab completion for set search_path TO  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Hello,

this patch https://commitfest.postgresql.org/action/patch_view?id=1443 is trivial with zero risk.

Patch is applicable without any issues, compilation was without any issues too.

Only one open question is there - should by system schemas visible for autocompleation  or not.

There was not 100% agreement in related discussion. I am inclined to think so preferable variant is without system schemas - they are used implicitly and has no sense use it on first position. But on second hand this detail is not significant and it is hard to get some objective arguments for one or second variant. Next, this behave can be simply changed without any impacts if we don't choose well now - so I would to mark this patch as ready for commit.

Regards

Pavel

pgsql-hackers by date:

Previous
From: "MauMau"
Date:
Subject: Re: proposal: new long psql parameter --on-error-stop
Next
From: Kevin Grittner
Date:
Subject: Re: delta relations in AFTER triggers