Thread: [patch] Potential relcache leak in get_object_address_attribute

Hi list,

It looks like the get_object_address_attribute() function has a
potential relcache leak. When missing_ok=true, the relation is found
but attribute is not, then the relation isn't closed, nor is it
returned to the caller.

I couldn't figure out any ways to trigger this, but it's best to fix anyway.

Regards,
Marti

On Sat, Jan 18, 2014 at 7:14 PM, Marti Raudsepp <marti@juffo.org> wrote:
> It looks like the get_object_address_attribute() function has a
> potential relcache leak. When missing_ok=true, the relation is found
> but attribute is not, then the relation isn't closed, nor is it
> returned to the caller.
>
> I couldn't figure out any ways to trigger this, but it's best to fix anyway.

I agree.  Committed, thanks for the patch.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company