Postgres Pro
Downloads
Home   >   mailing lists

Re: [patch] Potential relcache leak in get_object_address_attribute - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [patch] Potential relcache leak in get_object_address_attribute
Date
Msg-id CA+TgmoZdBvYrVMX0PuGFmGQ8jhjUEgDfaM0DSD3MfUjdWiCK8g@mail.gmail.com
Whole thread Raw
In response to [patch] Potential relcache leak in get_object_address_attribute  (Marti Raudsepp <marti@juffo.org>)
List pgsql-hackers
Tree view 
On Sat, Jan 18, 2014 at 7:14 PM, Marti Raudsepp <marti@juffo.org> wrote:
> It looks like the get_object_address_attribute() function has a
> potential relcache leak. When missing_ok=true, the relation is found
> but attribute is not, then the relation isn't closed, nor is it
> returned to the caller.
>
> I couldn't figure out any ways to trigger this, but it's best to fix anyway.

I agree.  Committed, thanks for the patch.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Why conf.d should be default, and auto.conf and recovery.conf should be in it
Next
From: Alvaro Herrera
Date:
Subject: Re: Add %z support to elog/ereport?