Thread: pg_xlogdump compiler warning
compat.c: In function ‘timestamptz_to_str’: compat.c:56:9: error: passing argument 1 of ‘localtime’ from incompatible pointer type [-Werror] In file included from compat.c:21:0: /usr/include/time.h:237:19: note: expected ‘const time_t *’ but argument is of type ‘pg_time_t *’ gcc 4.7.2
Hi, On 2013-02-25 18:15:48 -0500, Peter Eisentraut wrote: > compat.c: In function ‘timestamptz_to_str’: > compat.c:56:9: error: passing argument 1 of ‘localtime’ from incompatible pointer type [-Werror] > In file included from compat.c:21:0: > /usr/include/time.h:237:19: note: expected ‘const time_t *’ but argument is of type ‘pg_time_t *’ > > gcc 4.7.2 32bit I guess? A simple cast should do for now. Patch attached. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Attachment
Andres Freund <andres@2ndquadrant.com> writes:
> On 2013-02-25 18:15:48 -0500, Peter Eisentraut wrote:
>> compat.c: In function ‘timestamptz_to_str’:
>> compat.c:56:9: error: passing argument 1 of ‘localtime’ from incompatible pointer type [-Werror]
>> In file included from compat.c:21:0:
>> /usr/include/time.h:237:19: note: expected ‘const time_t *’ but argument is of type ‘pg_time_t *’
> 32bit I guess?
Yeah, I see the same on a 32-bit machine.
> A simple cast should do for now. Patch attached.
Pushed along with some other, more cosmetic cleanups.
regards, tom lane
On 2013-02-26 15:52:01 -0500, Tom Lane wrote: > Andres Freund <andres@2ndquadrant.com> writes: > > On 2013-02-25 18:15:48 -0500, Peter Eisentraut wrote: > >> compat.c: In function ‘timestamptz_to_str’: > >> compat.c:56:9: error: passing argument 1 of ‘localtime’ from incompatible pointer type [-Werror] > >> In file included from compat.c:21:0: > >> /usr/include/time.h:237:19: note: expected ‘const time_t *’ but argument is of type ‘pg_time_t *’ > > > 32bit I guess? > > Yeah, I see the same on a 32-bit machine. > > > A simple cast should do for now. Patch attached. > > Pushed along with some other, more cosmetic cleanups. Thanks. The statics's et al were stupid, my fault. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services