Re: pg_xlogdump compiler warning - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_xlogdump compiler warning
Date
Msg-id 21281.1361911921@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_xlogdump compiler warning  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: pg_xlogdump compiler warning  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> On 2013-02-25 18:15:48 -0500, Peter Eisentraut wrote:
>> compat.c: In function ‘timestamptz_to_str’:
>> compat.c:56:9: error: passing argument 1 of ‘localtime’ from incompatible pointer type [-Werror]
>> In file included from compat.c:21:0:
>> /usr/include/time.h:237:19: note: expected ‘const time_t *’ but argument is of type ‘pg_time_t *’

> 32bit I guess?

Yeah, I see the same on a 32-bit machine.

> A simple cast should do for now. Patch attached.

Pushed along with some other, more cosmetic cleanups.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PGXS contrib builds broken?
Next
From: David Fetter
Date:
Subject: Re: FILTER for aggregates [was Re: Department of Redundancy Department: makeNode(FuncCall) division]