Thread: Re: pg_basebackup is taking backup of extra files inside a tablespace directory
Re: pg_basebackup is taking backup of extra files inside a tablespace directory
From
Robert Haas
Date:
On Wed, Nov 28, 2012 at 1:55 AM, Hari Babu <haribabu.kommi@huawei.com> wrote: > I think backup should be done only files and folders present inside > '/opt/tblspc/PG_*' directory (TABLESPACE_VERSION_DIRECTORY). > Not all the files and folders in side '/opt/tblspc.' directory. I think I agree. The current behavior would have made sense in older releases of PG where we plopped down our stuff right inside the tablespace directory, but now that everything is being shoved in a subdirectory I don't see a reason to copy anything other than that subdirectory. Of course it's probably bad style to have anything that's not related to PG in there, but given that the whole point of this change was to allow different PG versions to create tablespaces on the same directory at the same time, we can hardly say that this is a case that should never arise in real life. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: pg_basebackup is taking backup of extra files inside a tablespace directory
From
Magnus Hagander
Date:
On Fri, Nov 30, 2012 at 8:30 PM, Robert Haas <robertmhaas@gmail.com> wrote: > On Wed, Nov 28, 2012 at 1:55 AM, Hari Babu <haribabu.kommi@huawei.com> wrote: >> I think backup should be done only files and folders present inside >> '/opt/tblspc/PG_*' directory (TABLESPACE_VERSION_DIRECTORY). >> Not all the files and folders in side '/opt/tblspc.' directory. > > I think I agree. The current behavior would have made sense in older > releases of PG where we plopped down our stuff right inside the > tablespace directory, but now that everything is being shoved in a > subdirectory I don't see a reason to copy anything other than that > subdirectory. Of course it's probably bad style to have anything > that's not related to PG in there, but given that the whole point of > this change was to allow different PG versions to create tablespaces > on the same directory at the same time, we can hardly say that this is > a case that should never arise in real life. Makes sense, yeah. Of course, anything stuffed *inside* said subdir will still be included, but that's violating that principle even more :) --Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/